Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'flutter create' plugin template issue #2519

Closed
stevemessick opened this issue Jul 31, 2018 · 3 comments
Closed

'flutter create' plugin template issue #2519

stevemessick opened this issue Jul 31, 2018 · 3 comments
Labels
platform-idea
Milestone
Backlog

Comments

@stevemessick
Copy link
Member

The template for plugins (used by flutter create) does not include any indication that example/lib is a source folder. It should. The .iml file needs to be updated in the Flutter repos.
@stevemessick stevemessick added this to the Backlog milestone Jul 31, 2018
@pq
Copy link
Contributor

pq commented Jul 31, 2018

Tangentially related, we don't treat example/lib as a source root when resolving links in the console either #2518.

@pq
Copy link
Contributor

pq commented Aug 1, 2018

Looking closer, this is not tangential at all. The way we resolve links is based on content roots so #2518 would get fixed by this. That said, adding example as a content root doesn't "just work" since it's nested below the base content root which is disallowed.

@stevemessick
Copy link
Member Author

Fixed via flutter/flutter#24311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform-idea
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@pq @stevemessick