Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter IntelliJ IDEA 2024.1 -- ActionUpdateThread.OLD_EDT is deprecated #7330

Closed
chardinson opened this issue Apr 5, 2024 · 4 comments · Fixed by #7415
Closed

Flutter IntelliJ IDEA 2024.1 -- ActionUpdateThread.OLD_EDT is deprecated #7330

chardinson opened this issue Apr 5, 2024 · 4 comments · Fixed by #7415
Assignees
Labels
Milestone

Comments

@chardinson
Copy link

What happened

I don't know

Version information

IntelliJ IDEA 2024.1 • Flutter plugin io.flutter 78.5.1 • Dart plugin 241.14768

Error getting Flutter sdk information.

Exception

null

com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'io.flutter.actions.ExtractWidgetAction' must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: io.flutter]
	at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
	at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:90)
	at com.intellij.diagnostic.PluginException.reportDeprecatedUsage(PluginException.java:125)
	at com.intellij.openapi.actionSystem.ActionUpdateThreadAware.getActionUpdateThread(ActionUpdateThreadAware.java:21)
	at com.intellij.openapi.actionSystem.AnAction.getActionUpdateThread(AnAction.java:199)
@chardinson chardinson changed the title Issue Flutter IntelliJ IDEA Issue Flutter IntelliJ IDEA 2024.1 Apr 5, 2024
@jacob314 jacob314 added the bug label Apr 5, 2024
@jacob314
Copy link
Contributor

jacob314 commented Apr 5, 2024

Use of a deprecated API that needs to be fixed soon so that important ExtractWidgetAction continues to work.

@helin24
Copy link
Member

helin24 commented Apr 8, 2024

We're not using the deprecated code directly in our plugin. I see this issue in IDEA that should be fixed now, but perhaps will remain for a while in 2024.1.

It seems like this is an issue within an IJ class somewhere in the inheritance chain of DefaultActionGroup, and should be fixed there rather than us needing to supply a non-deprecated thread type everywhere that we extend the class.

@j-fbriere
Copy link

Same problem for me.

IntelliJ IDEA 2024.1 • Flutter plugin io.flutter 78.5.1 • Dart plugin 241.15845

Flutter 3.19.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 300451adae (10 days ago) • 2024-03-27 21:54:07 -0500
Engine • revision e76c956498
Tools • Dart 3.3.3 • DevTools 2.31.1

@jwren jwren mentioned this issue Apr 10, 2024
@jwren
Copy link
Contributor

jwren commented Apr 10, 2024

This isn't just in the extract widget action, see #7341. io.flutter.actions.RunProfileFlutterApp

@jwren jwren changed the title Issue Flutter IntelliJ IDEA 2024.1 Flutter IntelliJ IDEA 2024.1 -- ActionUpdateThread.OLD_EDT is deprecated Apr 10, 2024
@jwren jwren added this to the M80 milestone Apr 10, 2024
@helin24 helin24 self-assigned this Apr 22, 2024
helin24 added a commit that referenced this issue May 7, 2024
Partially addresses
#7330

These are classes where there's clearly no UI manipulations happening in
`update` in either the direct classes or inheriting children.
jwren pushed a commit that referenced this issue May 8, 2024
Partially addresses #7330 

I'm not sure if these are needed since I wasn't seeing the deprecation
notice while using the device menu, but I looked through update
activities in these classes and it seems safe to make all of these BGT.

I think there is potentially a bug with emulator options:
#7409
jwren pushed a commit that referenced this issue May 8, 2024
helin24 added a commit that referenced this issue May 9, 2024
Fixes #7330
I think this covers the remaining actions that have been mentioned in
issues so far. There are more actions where I haven't updated the action
thread, but I suspect most of them are no longer used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants