Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scheduler] Support batch scheduling #100793

Closed
2 tasks done
CaseyHillers opened this issue Mar 25, 2022 · 6 comments · Fixed by flutter/cocoon#1971
Closed
2 tasks done

[scheduler] Support batch scheduling #100793

CaseyHillers opened this issue Mar 25, 2022 · 6 comments · Fixed by flutter/cocoon#1971
Assignees
Labels
team-infra Owned by Infrastructure team

Comments

@CaseyHillers
Copy link
Contributor

CaseyHillers commented Mar 25, 2022

Part of go/cocoon-scheduler

The current scheduler will always trigger runs. Before finishing the migration to the cocoon scheduler for flutter/flutter, it will need to support batch scheduling. This is because the DeviceLab doesn't have capacity to run on every commit.

@CaseyHillers
Copy link
Contributor Author

There's some issue where backfilling doesn't apply. I'll take a look

@keyonghan
Copy link
Contributor

There's some issue where backfilling doesn't apply. I'll take a look

Do you have the context what the issue is?

@CaseyHillers
Copy link
Contributor Author

I left Mac_arm64_android integration_test_test on the Cocoon scheduler for debugging. It's getting back Backfilling 0 builds

The culprit code is likely in https://cs.opensource.google/flutter/cocoon/+/main:app_dart/lib/src/request_handlers/scheduler/batch_backfiller.dart;l=57-79

@keyonghan
Copy link
Contributor

The culprit seems https://cs.opensource.google/flutter/cocoon/+/main:app_dart/lib/src/service/datastore.dart;l=145, it returns only 20 tasks which doesn't include those three tasks with a higher chance.

@keyonghan
Copy link
Contributor

Issue fixed, and back filling is working as expected.
Screen Shot 2022-07-12 at 9 06 28 PM

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-infra Owned by Infrastructure team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants