Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update popup menus to support Material 3 #101017

Closed
Tracked by #91605
guidezpl opened this issue Mar 30, 2022 · 3 comments · Fixed by #103606
Closed
Tracked by #91605

Update popup menus to support Material 3 #101017

guidezpl opened this issue Mar 30, 2022 · 3 comments · Fixed by #103606
Assignees
@TahaTesser
Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list
Projects
Material 3 (Deprecated by https://git...

Comments

@guidezpl
Copy link
Member

guidezpl commented Mar 30, 2022 •
edited by HansMuller

As part of the Material 3 specification there are updates to Popup Menu's visuals:

popup_menu

We should update the PopupMenuX classes to support this Material 3 look.
@guidezpl guidezpl mentioned this issue Mar 30, 2022
Closed
70 tasks
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: proposal A detailed proposal for a change to Flutter and removed in triage Presently being triaged by the triage team labels Mar 30, 2022
@guidezpl guidezpl changed the title Update Menus buttons to support Material 3 Update Menus to support Material 3 Apr 27, 2022
@TahaTesser TahaTesser self-assigned this May 10, 2022
@TahaTesser
Copy link
Member

Menu tokens are available, working on this migration.

@TahaTesser TahaTesser mentioned this issue May 12, 2022
Merged
8 tasks
@HansMuller HansMuller changed the title Update Menus to support Material 3 Update PopupMenus to support Material 3 May 13, 2022
@HansMuller HansMuller changed the title Update PopupMenus to support Material 3 Update popup menus to support Material 3 May 13, 2022
@guidezpl guidezpl changed the title Update popup menus to support Material 3 Update Popup Menus to support Material 3 May 21, 2022
@guidezpl guidezpl changed the title Update Popup Menus to support Material 3 Update popup menus to support Material 3 May 24, 2022
@TahaTesser TahaTesser mentioned this issue Jun 1, 2022
Closed
@jpnurmi jpnurmi mentioned this issue Jun 10, 2022
Closed
@rydmike rydmike mentioned this issue Jul 13, 2022
Closed
@Piinks Piinks added P2 Important issues not at the top of the work list waiting for PR to land (fixed) A fix is in flight labels Oct 20, 2022
@TahaTesser
Copy link
Member

TahaTesser commented Oct 25, 2022 •
edited

#103606 landed

@TahaTesser TahaTesser removed the waiting for PR to land (fixed) A fix is in flight label Oct 25, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TahaTesser TahaTesser

Labels
c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list
Projects
Nevercode
Status: Done (PR merged)
Material 3
Status: ✅ Done
Material 3 (Deprecated by https://git...
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Popup Menu to support Material 3 NevercodeHQ/flutter
4 participants
@guidezpl @Piinks @TahaTesser @danagbemava-nc