Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] M3 AppBar support #102697

Closed
darrenaustin opened this issue Apr 27, 2022 · 3 comments
Closed

[CP] M3 AppBar support #102697

darrenaustin opened this issue Apr 27, 2022 · 3 comments
Assignees
Labels
cp: approved Approved cherry-pick request cp: review Cherry-picks in the review queue f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@darrenaustin
Copy link
Contributor

issue_link

#92093

Commit Hash

14a9b4a

Target

beta

Impacted Users

Apps that are opting into Material 3.

Impact Description

This change should have no impact on existing apps, but provides opt-in support for the Material 3 design of App Bars.

Workaround

There is nothing really to work around, but if apps wanted to support the M3 look for AppBars they would have to do a lot of work to the existing AppBar to make it happen.

Risk

low

Test Coverage

yes

Validation Steps

This should already be covered by the automated tests (and I ran this against all the internal tests as well). To manually check this, if you just bring up the counter example the app bar should look like a normal Material 2 app bar (i.e. blue background with white text). If you add useMaterial3: true to the ThemeData used by the counter app it should switch to a white background with black text.

@darrenaustin darrenaustin added the cp: review Cherry-picks in the review queue label Apr 27, 2022
@itsjustkevin
Copy link
Contributor

@HansMuller

@HansMuller HansMuller added the cp: approved Approved cherry-pick request label May 2, 2022
@muditatandon muditatandon added the framework flutter/packages/flutter repository. See also f: labels. label May 3, 2022
@goderbauer goderbauer added the f: material design flutter/packages/flutter/material repository. label May 4, 2022
@CaseyHillers
Copy link
Contributor

Landed in last weeks hotfix #103101

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cp: approved Approved cherry-pick request cp: review Cherry-picks in the review queue f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants