Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IconButton to support Material 3 #103528

Closed
Tracked by #91605
darrenaustin opened this issue May 11, 2022 · 3 comments · Fixed by #106437 or #105176
Closed
Tracked by #91605

Update IconButton to support Material 3 #103528

darrenaustin opened this issue May 11, 2022 · 3 comments · Fixed by #106437 or #105176
Assignees
@QuncCccccc
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
Material 3 (Deprecated by https://git...

Comments

@darrenaustin
Copy link
Contributor

As part of the Material 3 specification there are updates to the Icon button's visuals as well as optional support for toggle states:

Screen Shot 2022-05-11 at 12 54 48 PM

If possible we should investigate adding these to the existing IconButton class to support these.
@darrenaustin darrenaustin added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 11, 2022
@darrenaustin darrenaustin mentioned this issue May 11, 2022
Closed
70 tasks
@bernaferrari
Copy link
Contributor

bernaferrari commented May 14, 2022 •
edited

I guess, from looking at the guidelines, that's the end of the the 'huge ripple effect' the IconButton has when you hover/click?

@guidezpl guidezpl changed the title Update IconButton to support Material 3 Update IconButton to support Material 3 May 24, 2022
@QuncCccccc
Copy link
Contributor

I guess, from looking at the guidelines, that's the end of the the 'huge ripple effect' the IconButton has when you hover/click?

Yes, the updated IconButton will look like the other common buttons(TextButton, OutlinedButton and etc) without text.

@QuncCccccc QuncCccccc mentioned this issue Jun 1, 2022
Merged
8 tasks
@QuncCccccc QuncCccccc mentioned this issue Jun 22, 2022
Merged
8 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@QuncCccccc QuncCccccc

Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
No open projects
Material 3
Status: ✅ Done
Material 3 (Deprecated by https://git...
  
Planned
Milestone
No milestone
3 participants
@darrenaustin @bernaferrari @QuncCccccc