Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_maps_flutter_web] Add missing MapOptions parameters #104111

Open
sperochon opened this issue May 18, 2022 · 1 comment
Open

[google_maps_flutter_web] Add missing MapOptions parameters #104111

sperochon opened this issue May 18, 2022 · 1 comment
Labels
c: new feature Nothing broken; request for a new capability c: parity Works on one platform but not another c: proposal A detailed proposal for a change to Flutter has partial patch There is a PR awaiting someone to take it across the finish line p: maps Google Maps plugin P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team

Comments

@sperochon
Copy link

Use case

On Flutter WEB, I would like to be able to enable/disable (via GoogleMap constructor params or whatever) those MapOptions parameters:
mapTypeControl
fullscreenControl
streetViewControl

that display additional buttons onto the Map.
image

Proposal

In the code of the package it is written (more than 15 months ago):

  // These don't have any rawOptions entry, but they seem to be off in the native maps.
  options.mapTypeControl = false;
  options.fullscreenControl = false;
  options.streetViewControl = false;

I have switched them all to "true" and it is working fine (= enables all the buttons and gives the previous screenshot). I tried each button and everything is working fine. So, it seems that the comment in the code is not true anymore.

Thanks!

@darshankawar darshankawar added in triage Presently being triaged by the triage team c: new feature Nothing broken; request for a new capability p: maps Google Maps plugin platform-web Web applications specifically c: proposal A detailed proposal for a change to Flutter plugin and removed in triage Presently being triaged by the triage team labels May 19, 2022
@yjbanov yjbanov added P3 Issues that are less important to the Flutter project c: parity Works on one platform but not another labels May 19, 2022
@yjbanov yjbanov added this to Not Started in Flutter Web Plugins via automation May 19, 2022
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
@Hixie Hixie removed the plugin label Jul 6, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-web Owned by Web platform team triaged-web Triaged by Web platform team labels Jul 8, 2023
@stuartmorgan
Copy link
Contributor

If anyone is interested in addressing this, there was a work-in-progress PR at flutter/packages#4553 that could be used as a starting point.

@stuartmorgan stuartmorgan added the has partial patch There is a PR awaiting someone to take it across the finish line label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: new feature Nothing broken; request for a new capability c: parity Works on one platform but not another c: proposal A detailed proposal for a change to Flutter has partial patch There is a PR awaiting someone to take it across the finish line p: maps Google Maps plugin P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
Flutter Web Plugins
  
Not Started
Development

Successfully merging a pull request may close this issue.

5 participants