Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google_maps_flutter] ios, avoid sending message to self in init #104121

Open
cyanglaz opened this issue May 18, 2022 · 0 comments
Open

[google_maps_flutter] ios, avoid sending message to self in init #104121

cyanglaz opened this issue May 18, 2022 · 0 comments
Labels
p: maps Google Maps plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team

Comments

@cyanglaz
Copy link
Contributor

The FLTGoogleMapController's init method has several places sending message to self in the middle of the init method.
See :https://github.com/flutter/plugins/blob/main/packages/google_maps_flutter/google_maps_flutter/ios/Classes/GoogleMapController.m#L70-L132

We should refactor and avoid sending messages to self in the middle of the init methods.
@cyanglaz cyanglaz added platform-ios iOS applications specifically plugin p: maps Google Maps plugin P2 Important issues not at the top of the work list labels May 18, 2022
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
@Hixie Hixie removed the plugin label Jul 6, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: maps Google Maps plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stuartmorgan @Hixie @cyanglaz