Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android compiling] Use the same linting rules as those in g3 #104528

Open
dkwingsmt opened this issue May 24, 2022 · 2 comments
Open

[Android compiling] Use the same linting rules as those in g3 #104528

dkwingsmt opened this issue May 24, 2022 · 2 comments
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team

Comments

@dkwingsmt
Copy link
Contributor

dkwingsmt commented May 24, 2022 •
edited

One of my PR that could be built and run on my local machine was blocked by g3, and had to be reverted. The error turns out to be a linting rule that requires the suffix for long long to be L instead of l (see here for my fix to reland it).

We should keep our linting rule up to date with the ones in g3, or at least add this rule in to prevent this kind of reverts further happening.
@dkwingsmt dkwingsmt added platform-android Android applications specifically a: build Building flutter applications with the tool labels May 24, 2022
@dkwingsmt
Copy link
Contributor Author

Another case (of a different reason) has occurred and made us revert a PR.

@dkwingsmt
Copy link
Contributor Author

cc @blasten

@stuartmorgan stuartmorgan added engine flutter/engine repository. See also e: labels. and removed a: build Building flutter applications with the tool labels Jul 20, 2022
@chinmaygarde chinmaygarde added c: tech-debt Technical debt, code quality, testing, etc. P2 Important issues not at the top of the work list labels Jul 25, 2022
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chinmaygarde @stuartmorgan @Hixie @dkwingsmt