Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default debug creator chain clipping is too aggressive #104582

Open
dnfield opened this issue May 25, 2022 · 1 comment
Open

Default debug creator chain clipping is too aggressive #104582

dnfield opened this issue May 25, 2022 · 1 comment
Labels
a: debugging Debugging, breakpoints, expression evaluation d: devtools DevTools related - suite of performance and debugging tools framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@dnfield
Copy link
Contributor

dnfield commented May 25, 2022

When dealing with large/deeply nested widget trees, error messages that rely on DebugCreator.toString cut off too quickly, often not showing me enough context to see what widget(s) in the application are offending.

We should bump the default limit of 12 up to something higher. I'm not clear on the implications of this for devtools.

@kenzieschmoll WDYT?

/cc @goderbauer @chunhtai
@dnfield dnfield added framework flutter/packages/flutter repository. See also f: labels. a: debugging Debugging, breakpoints, expression evaluation d: devtools DevTools related - suite of performance and debugging tools P2 Important issues not at the top of the work list labels May 25, 2022
@kenzieschmoll
Copy link
Member

DevTools will show error messages in its console, both in the inspector screen and the debugger screen. If having a stack depth greater than 12 will make these errors more actionable, then this sgtm. Shouldn't be an issue from the devtools perspective.

@flutter-triage-bot flutter-triage-bot bot added team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: debugging Debugging, breakpoints, expression evaluation d: devtools DevTools related - suite of performance and debugging tools framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnfield @kenzieschmoll