FlutterFragment forced to visiable when Activity resumed #105203

zxjzerg · 2022-06-02T08:28:11Z

I use FlutterFragment as a Tab in my application. After I upgrade Flutter to 3.0.0 I meet an issue that if the FlutterFragment is set to hidden, when the Activity resumes, the FlutterFragment will become visiable.
This not happen when I use Flutter 2.10.5.

Project for reproducing this issue

I read the souce code of FlutterActivityAndFragmentDelegat in Flutter 3.0.0 and find out when the Fragment's onStart is called, it set the FlutterView to visiable. This changes are introduced by #30897.

void onStart() {
  Log.v(TAG, "onStart()");
  ensureAlive();
  doInitialFlutterViewRun();
  // This is a workaround for a bug on some OnePlus phones. The visibility of the application
  // window is still true after locking the screen on some OnePlus phones, and shows a black
  // screen when unlocked. We can work around this by changing the visibility of FlutterView in
  // onStart and onStop.
  // See https://github.com/flutter/flutter/issues/93276
  flutterView.setVisibility(View.VISIBLE);
}

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.0.1, on macOS 11.6.5 20G527 darwin-x64, locale
    en-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version
    33.0.0-rc2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.67.2)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

The text was updated successfully, but these errors were encountered:

zxjzerg · 2022-06-02T08:29:36Z

@ColdPaleLight pls check this

exaby73 · 2022-06-02T09:46:04Z

I can replicate this behavior. Though one thing to note, I have noticed that when I tap on "Recent apps" button, then immediately go back to the app, the view is still invisible. It's when I tap on the "Home" button, then resume the app is when this bug occurs.

flutter doctor -v (Stable)

[✓] Flutter (Channel stable, 3.0.1, on macOS 12.4 21F79 darwin-arm, locale en-US)
    • Flutter version 3.0.1 at /Users/nabeelparkar/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fb57da5f94 (12 days ago), 2022-05-19 15:50:29 -0700
    • Engine revision caaafc5604
    • Dart version 2.17.1
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/nabeelparkar/Library/Android/sdk/
    • Platform android-32, build-tools 32.1.0-rc1
    • ANDROID_SDK_ROOT = /Users/nabeelparkar/Library/Android/sdk/
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Brave Browser.app/Contents/MacOS/Brave Browser

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Ultimate Edition (version 2022.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 67.1.4
    • Dart plugin version 221.5591.58

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Brave Browser 102.1.39.111

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

flutter doctor -v (Master)

[✓] Flutter (Channel master, 3.1.0-0.0.pre.1035, on macOS 12.4 21F79 darwin-arm, locale en-US)
    • Flutter version 3.1.0-0.0.pre.1035 at /Users/nabeelparkar/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 3d62732d60 (2 hours ago), 2022-06-01 00:14:14 -0400
    • Engine revision 0d1057ef7b
    • Dart version 2.18.0 (build 2.18.0-157.0.dev)
    • DevTools version 2.13.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at /Users/nabeelparkar/Library/Android/sdk/
    • Platform android-32, build-tools 32.1.0-rc1
    • ANDROID_SDK_ROOT = /Users/nabeelparkar/Library/Android/sdk/
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Brave Browser.app/Contents/MacOS/Brave Browser

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Ultimate Edition (version 2022.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 67.1.4
    • Dart plugin version 221.5591.58

[✓] VS Code (version 1.67.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Brave Browser 102.1.39.111

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

ColdPaleLight · 2022-07-12T07:22:40Z

Closing it var linked PR

github-actions · 2022-07-26T08:00:53Z

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

ColdPaleLight · 2022-08-24T10:28:11Z

flutter/engine#30897 (comment)

Nayuta403 · 2022-08-30T06:44:23Z

There are two issues to be addressed here：

flutterView.getVisibility() sometimes it's not accurate, use flutterView.isShown() is more accurate.

For example, nesting a FlutterFragment in FragmentA and setting FragmentA to View.GONE , it does not work for FlutterFragment. flutterView.getVisibility() is still VISIBLE.

https://github.com/flutter/engine/blob/51d14176b6dad39ca707f7916cf528c2aacd6652/shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java#L605

This problem can be reproduced in this project code ：d6dad6cbaabacc68f43406a50fc216c9fa752ccc

flutterView.setVisibility(View.GONE) does not work for FlutterSurfaceView. We need to set Visibility extra to FlutterSurfaceView.

After calling flutterView.setVisibility(View.GONE), switching from the background to the foreground flutterview will still be displayed.For FlutterSurfaceView, setting View.GONE to the current FlutterView will not take effect since it is not in the view tree.

This problem can be reproduced in this project code ：main

This problem was solved when I changed it to texture

For these two questions, I will finish PR later

gmackall · 2023-06-15T18:27:09Z

@zxjzerg It looks like there was a PR marked as fixing this issue that was merged in September. Can you confirm the fix?

github-actions · 2023-07-06T19:08:14Z

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now.
If you find this problem please file a new issue with the same description, what happens, logs and the output of 'flutter doctor -v'. All system setups can be slightly different so it's always better to open new issues and reference the related ones.
Thanks for your contribution.

github-actions · 2023-07-20T20:00:55Z

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

exaby73 added the in triage Presently being triaged by the triage team label Jun 2, 2022

ColdPaleLight self-assigned this Jun 2, 2022

ColdPaleLight mentioned this issue Jul 12, 2022

Set the 'visibility' of 'FlutterView' to the previous one in 'FragmentActivityAndFragment.onStart' flutter/engine#34601

Merged

8 tasks

ColdPaleLight closed this as completed Jul 12, 2022

exaby73 added the r: fixed Issue is closed as already fixed in a newer version label Jul 12, 2022

github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2022

chdo002 mentioned this issue Aug 24, 2022

问题解决了么 zxjzerg/FlutterFragmentIssueDemo#1

Closed

ColdPaleLight reopened this Aug 24, 2022

danagbemava-nc removed the r: fixed Issue is closed as already fixed in a newer version label Aug 24, 2022

exaby73 added has reproducible steps The issue has been confirmed reproducible and is ready to work on engine flutter/engine repository. See also e: labels. labels Aug 24, 2022

flutter unlocked this conversation Aug 30, 2022

stuartmorgan added P2 Important issues not at the top of the work list c: regression It was better in the past than it is now labels Aug 30, 2022

Nayuta403 mentioned this issue Sep 4, 2022

Surface will be created again after the front and back switches flutter/engine#35767

Merged

8 tasks

guoguo338 mentioned this issue Nov 22, 2022

fix the SurfaceView not hide issue. flutter/engine#37669

Closed

8 tasks

gmackall added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jun 15, 2023

github-actions bot closed this as completed Jul 6, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FlutterFragment forced to visiable when Activity resumed #105203

FlutterFragment forced to visiable when Activity resumed #105203

zxjzerg commented Jun 2, 2022

zxjzerg commented Jun 2, 2022

exaby73 commented Jun 2, 2022

ColdPaleLight commented Jul 12, 2022

github-actions bot commented Jul 26, 2022

ColdPaleLight commented Aug 24, 2022

Nayuta403 commented Aug 30, 2022

gmackall commented Jun 15, 2023

github-actions bot commented Jul 6, 2023

github-actions bot commented Jul 20, 2023

FlutterFragment forced to visiable when Activity resumed #105203

FlutterFragment forced to visiable when Activity resumed #105203

Comments

zxjzerg commented Jun 2, 2022

zxjzerg commented Jun 2, 2022

exaby73 commented Jun 2, 2022

ColdPaleLight commented Jul 12, 2022

github-actions bot commented Jul 26, 2022

ColdPaleLight commented Aug 24, 2022

Nayuta403 commented Aug 30, 2022

gmackall commented Jun 15, 2023

github-actions bot commented Jul 6, 2023

github-actions bot commented Jul 20, 2023