Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownButtonFormField should allow definition of underline #109099

Open
gildurao opened this issue Aug 6, 2022 · 1 comment
Open

DropdownButtonFormField should allow definition of underline #109099

gildurao opened this issue Aug 6, 2022 · 1 comment
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@gildurao
Copy link

gildurao commented Aug 6, 2022

Use case

As a dev, I want to be able to customize my DropdownButtonFormFields to the fullest possibilities. Therefore, I should be able to inject a custom underline Widget

Proposal

Add an underline argument to DropdownButtonFormField constructor:

DropdownButtonFormField({
    Key? key,
    required List<DropdownMenuItem<T>>? items,
    DropdownButtonBuilder? selectedItemBuilder,
    T? value,
    Widget? hint,
    Widget? disabledHint,
    required this.onChanged,
    VoidCallback? onTap,
    int elevation = 8,
    TextStyle? style,
    Widget? icon,
    Color? iconDisabledColor,
    Color? iconEnabledColor,
    double iconSize = 24.0,
    bool isDense = true,
    bool isExpanded = false,
    double? itemHeight,
    Color? focusColor,
    FocusNode? focusNode,
    bool autofocus = false,
    Color? dropdownColor,
    InputDecoration? decoration,
    FormFieldSetter<T>? onSaved,
    FormFieldValidator<T>? validator,
    AutovalidateMode? autovalidateMode,
    double? menuMaxHeight,
    bool? enableFeedback,
    AlignmentGeometry alignment = AlignmentDirectional.centerStart,
    BorderRadius? borderRadius,
    Widget? underline, // <------------------------------------------------
    // When adding new arguments, consider adding similar arguments to
    // DropdownButton.
  })

DropdownButtonHideUnderline does not seem to be working, could it be a bug?

@danagbemava-nc danagbemava-nc added the in triage Presently being triaged by the triage team label Aug 8, 2022
@danagbemava-nc danagbemava-nc changed the title DropdownButtonFormField should allow definition of underline (DropdownButtonHideUnderline does not work) DropdownButtonFormField should allow definition of underline Aug 8, 2022
@danagbemava-nc
Copy link
Member

Related #80416

Hi @gildurao, kindly file a new issue and provide the relevant information required to reproduce the issue you're facing with DropdownButtonHideUnderline so that we can investigate it.

Thank you

@danagbemava-nc danagbemava-nc added c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. and removed in triage Presently being triaged by the triage team labels Aug 8, 2022
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-design Owned by Design Languages team triaged-design Triaged by Design Languages team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Development

No branches or pull requests

3 participants