Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Host Engine flakes on ShellTest #109332

Closed
keyonghan opened this issue Aug 10, 2022 · 7 comments
Closed

Mac Host Engine flakes on ShellTest #109332

keyonghan opened this issue Aug 10, 2022 · 7 comments
Labels
c: flake Tests that sometimes, but not always, incorrectly pass engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@keyonghan
Copy link
Contributor

keyonghan commented Aug 10, 2022

@keyonghan keyonghan added engine flutter/engine repository. See also e: labels. P1 c: flake Tests that sometimes, but not always, incorrectly pass labels Aug 10, 2022
@chinmaygarde
Copy link
Member

We'll have to take a look at this more closely. We did not verify the logic around the signaling of the waiting_for_first_frame_condition_ CV in the test fixture.

@keyonghan How often is this happening?

@keyonghan
Copy link
Contributor Author

keyonghan commented Aug 15, 2022

We'll have to take a look at this more closely. We did not verify the logic around the signaling of the waiting_for_first_frame_condition_ CV in the test fixture.

@keyonghan How often is this happening?

By the time I filed this bug, it flaked twice (those two listed in the bug description) in the recent 100 commits.

@chinmaygarde
Copy link
Member

I took a look at this the other day and the issue may be in latching around a utility in the fixture itself. So it should affect all tests that wait for frames. I haven't had a chance to take a closer look at fixing this. If this has no takers this week, I can spend some time getting to the bottom of it.

@zanderso
Copy link
Member

Over the last ~100 builds Mac Host Engine has flaked only twice, so I am going to reduce the priority of this relative some work that's happening for the upcoming stable.

@zanderso zanderso added P1 High-priority issues at the top of the work list and removed P1 labels Aug 23, 2022
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team and removed triaged-engine Triaged by Engine team labels Jul 8, 2023
@flutter-triage-bot
Copy link

This issue is assigned but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@zanderso zanderso removed their assignment Jul 10, 2023
@zanderso zanderso added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels Jul 10, 2023
@chinmaygarde chinmaygarde added the triaged-engine Triaged by Engine team label Jul 17, 2023
@zanderso
Copy link
Member

Closing as presumed stale.

Copy link

github-actions bot commented Feb 7, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: flake Tests that sometimes, but not always, incorrectly pass engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Development

No branches or pull requests

3 participants