Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Refactor FilterContents to make it more testable. #109795

Open
bdero opened this issue Aug 18, 2022 · 2 comments
Open

[Impeller] Refactor FilterContents to make it more testable. #109795

bdero opened this issue Aug 18, 2022 · 2 comments
Labels
c: proposal A detailed proposal for a change to Flutter e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@bdero
Copy link
Member

bdero commented Aug 18, 2022

Now that RenderFilter has an interface which exposes a snapshot, some of the trickery in the blur filter and friends can be tested here. These implementation details shouldn't be exposed to the public API, but making some stuff public might make sense just for testability.
@bdero bdero added the e: impeller Impeller rendering backend issues and features requests label Aug 18, 2022
@bdero bdero self-assigned this Aug 18, 2022
@bdero bdero mentioned this issue Aug 18, 2022
Merged
@danagbemava-nc danagbemava-nc added engine flutter/engine repository. See also e: labels. c: proposal A detailed proposal for a change to Flutter labels Sep 27, 2022
@chinmaygarde chinmaygarde added the P1 High-priority issues at the top of the work list label Oct 3, 2022
@chinmaygarde
Copy link
Member

@bdero Are you actively working on this? Mind if I put it back in the non-In-Progress pile?

@bdero bdero removed their assignment Oct 20, 2022
@bdero
Copy link
Member Author

bdero commented Oct 20, 2022

Not at the moment, moving it SGTM.

@chinmaygarde chinmaygarde added P3 Issues that are less important to the Flutter project and removed P1 High-priority issues at the top of the work list labels Dec 9, 2022
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: proposal A detailed proposal for a change to Flutter e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
No open projects
Impeller
Status: 🛠️ Internals
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chinmaygarde @bdero @danagbemava-nc