Ship FlutterMacOS.framework as unzipped inside the Mac host artifacts

[jmagman]

The FlutterMacOS.framework artifact is packaged as a zip that contains another zip.

FlutterMacOS.framework.zip

See example at https://storage.googleapis.com/flutter_infra_release/flutter/d1b9a6938ad77326ac3a94d92bbc77933ed829ed/darwin-x64-release/FlutterMacOS.framework.zip

Stop zipping FlutterMacOS.framework within the artifact zip. When complete, the zip should contain:

FlutterMacOS.framework

This requires an incremental step of shipping with both the FlutterMacOS.framework.zip and unzipped FlutterMacOS.framework in the same directory, which will double the size of the artifact from 11M to 22M. Having both will allow the tool and g3 roll to adopt the unzipped variant. Then, once adopted everywhere, delete the zip.

Tool changes (there may be more spots):

flutter/packages/flutter_tools/lib/src/commands/build_macos_framework.dart

Line 167 in 7f1a8f7

s.prepare_command = 'unzip FlutterMacOS.framework -d FlutterMacOS.framework'

and

flutter/packages/flutter_tools/lib/src/cache.dart

Line 917 in 4b361cc

operatingSystemUtils.unzip(frameworkZip, framework);

Roller changes:
https://source.corp.google.com/piper///depot/google3/mobile/flutter/tools/frob/roll_job/lib/src/cache_fetcher.dart;l=271-276?q=fluttermacos.framework&ss=piper%2FGoogle%2FPiper:google3%2Fmobile%2Fflutter%2Ftools%2F

https://source.corp.google.com/piper///depot/google3/mobile/flutter/tools/frob/roll_job/lib/src/cache_fetcher.dart;l=74-77?q=fluttermacos.framework&ss=piper%2FGoogle%2FPiper:google3%2Fmobile%2Fflutter%2Ftools%2F

This needs to be completed as part of #81855 per flutter/engine#35563.

See also where this was done for the Flutter.framework.zip to unzipped Flutter.xcframework:
Tool changes: #71495
Added unzip https://flutter-review.googlesource.com/c/recipes/+/9020
Related bug for roll script: b/issues/172736803#comment7
Removed zip https://flutter-review.googlesource.com/c/recipes/+/9560

[jmagman]

This requires an incremental step of shipping with both the FlutterMacOS.framework.zip and unzipped FlutterMacOS.framework in the same directory, which will double the size of the artifact from 11M to 22M. Having both will allow the tool and g3 roll to adopt the unzipped variant. Then, once adopted everywhere, delete the zip.

This needs to be completed as part of #81855 per flutter/engine#35563.

Alternatively, I can prep the tool work needed to be used when engine_v2 goes into effect, and the rollers can make the script changes when the engine_v2 artifacts first roll in.

[jmagman]

Closing, this actually already happened in May. First seen in #103387, maybe somehow because of my change in https://flutter-review.googlesource.com/c/recipes/+/29840 ?

This is a more recent example than the link in my description: https://pantheon.corp.google.com/storage/browser/_details/flutter_infra_release/flutter/bbe0038e2a36e100bf0f0612cbb90163d02b257b/darwin-x64/FlutterMacOS.framework.zip;tab=live_object

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.