Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose of Paragraph objects in the framework #110601

Closed
dnfield opened this issue Aug 30, 2022 · 2 comments
Closed

Dispose of Paragraph objects in the framework #110601

dnfield opened this issue Aug 30, 2022 · 2 comments
Assignees
@dnfield
Labels
framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list perf: memory Performance issues related to memory

Comments

@dnfield
Copy link
Contributor

dnfield commented Aug 30, 2022

Paragraph now has a dispose method.

RenderObjects that create a Paragraph (which is usually done via TextPainter) should dispose them when the RO gets disposed.
@dnfield dnfield added framework flutter/packages/flutter repository. See also f: labels. perf: memory Performance issues related to memory P2 Important issues not at the top of the work list labels Aug 30, 2022
@dnfield dnfield self-assigned this Aug 30, 2022
@dnfield dnfield added the P1 High-priority issues at the top of the work list label Aug 30, 2022
@dnfield
Copy link
Contributor Author

dnfield commented Aug 30, 2022

Ihave a local patch that does most of this. Need to figure out if/how to test it.

@dnfield dnfield mentioned this issue Aug 30, 2022
Merged
@ColdPaleLight ColdPaleLight removed the P2 Important issues not at the top of the work list label Aug 31, 2022
@dnfield dnfield closed this as completed Nov 10, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dnfield dnfield

Labels
framework flutter/packages/flutter repository. See also f: labels. P1 High-priority issues at the top of the work list perf: memory Performance issues related to memory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnfield @ColdPaleLight