Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera_android] Add support to manipulate focus distance and focus mode manually #111476

Open
abo-el30la opened this issue Sep 13, 2022 · 8 comments
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter p: camera The camera plugin P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team

Comments

@abo-el30la
Copy link

Use case

in https://pub.dev/packages/camera
I need to manipulate focus distance manually
specifically this feature --
set(CaptureRequest.CONTROL_AF_MODE, CaptureRequest.CONTROL_AF_MODE_OFF)
set(CaptureRequest.LENS_FOCUS_DISTANCE, value)
these methods are available on android camera2 for CaptureRequest.Builder

thanks in advance

@abo-el30la
Copy link
Author

this my try to change LENS_FOCUS_DISTANCE manually
Screenshot 2022-09-13 161546

@huycozy huycozy added the in triage Presently being triaged by the triage team label Sep 14, 2022
@huycozy
Copy link
Member

huycozy commented Sep 14, 2022

Hi @abo-el30la
It looks like you are filing a proposal/feature request. Please try to update the issue by the template so it will have better readability.

Issue Template
<!-- Thank you for using Flutter!

     If you are looking for support, please check out our documentation
     or consider asking a question on Stack Overflow:
      * https://flutter.dev/
      * https://api.flutter.dev/
      * https://stackoverflow.com/questions/tagged/flutter?sort=frequent

     If you have found a bug or if our documentation doesn't have an answer
     to what you're looking for, then fill out the template below. Please read
     our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->

## Use case

<!--
     Please tell us the problem you are running into that led to you wanting
     a new feature.

     Is your feature request related to a problem? Please give a clear and
     concise description of what the problem is.

     Describe the alternative solutions you've considered. Is there a package
     on pub.dev/flutter that already solves this?
-->

## Proposal

<!--
     Briefly but precisely describe what you would like Flutter to be able to do.

     Consider attaching something showing what you are imagining:
      * images
      * videos
      * code samples

     Does this have to be provided by Flutter directly, or can it be provided
     by a package on pub.dev/flutter? If so, maybe consider implementing and
     publishing such a package rather than filing a bug.
-->

Thank you!

@huycozy huycozy added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 14, 2022
@abo-el30la

This comment was marked as duplicate.

@github-actions github-actions bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 14, 2022
@huycozy
Copy link
Member

huycozy commented Sep 14, 2022

Hi @abo-el30la
Please don't repeat the same description in the comments. I propose a new description as below:


Usecase

I need to manipulate focus distance and focus mode manually. These methods are available on android camera2 for CaptureRequest.Builder:

set(CaptureRequest.CONTROL_AF_MODE, CaptureRequest.CONTROL_AF_MODE_OFF)
set(CaptureRequest.LENS_FOCUS_DISTANCE, value)

Proposal

Support this feature on camera_android


If you agree/disagree about this, please write in the comments. Thanks!

@huycozy huycozy added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 14, 2022
@abo-el30la
Copy link
Author

yes , I agree

@github-actions github-actions bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Sep 14, 2022
@huycozy
Copy link
Member

huycozy commented Sep 14, 2022

Thank you for confirming. Labeling this issue as a feature request.

@huycozy huycozy added c: new feature Nothing broken; request for a new capability plugin p: camera The camera plugin c: proposal A detailed proposal for a change to Flutter platform-android Android applications specifically and removed in triage Presently being triaged by the triage team labels Sep 14, 2022
@huycozy huycozy changed the title camera plugin [camera_android] Add support to manipulate focus distance and focus mode manually Sep 14, 2022
@stuartmorgan stuartmorgan added the P3 Issues that are less important to the Flutter project label Sep 15, 2022
@abo-el30la
Copy link
Author

abo-el30la commented Sep 18, 2022

is this feature will be available soon? @stuartmorgan

@stuartmorgan
Copy link
Contributor

Please see https://github.com/flutter/flutter/wiki/Issue-hygiene#when-will-my-bug-be-fixed.

@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
@Hixie Hixie removed the plugin label Jul 6, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter p: camera The camera plugin P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
None yet
Development

No branches or pull requests

4 participants