Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix addToScene documentation #113987

Merged
merged 1 commit into from Nov 1, 2022
Merged

Fix addToScene documentation #113987

merged 1 commit into from Nov 1, 2022

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Oct 25, 2022

Its return type is void, but doc says "return the engine layer", so I guess the doc is outdated.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 25, 2022
@goderbauer
Copy link
Member

Looks like this was changed in #36402, but we never updated the doc (cc @yjbanov).

goderbauer
goderbauer approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 26, 2022

Looks like this was changed in #36402, but we never updated the doc (cc @yjbanov).

I agree. That's why the PR happens :)

justinmc
justinmc approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for putting in the effort to clean this up!

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 27, 2022

You are welcome!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2022
@auto-submit auto-submit bot merged commit c23b5ca into flutter:master Nov 1, 2022
This was referenced Nov 2, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
c23b5ca7d Fix addToScene documentation (flutter/flutter#113987)
2373a27
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
c23b5ca Fix addToScene documentation (flutter/flutter#113987)
eb17dbc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
c23b5ca7d Fix addToScene documentation (flutter/flutter#113987)
de37c7b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
c23b5ca Fix addToScene documentation (flutter/flutter#113987)
7372e22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
c23b5ca7d Fix addToScene documentation (flutter/flutter#113987)
a7ae231
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
c23b5ca Fix addToScene documentation (flutter/flutter#113987)
413241c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
c23b5ca Fix addToScene documentation (flutter/flutter#113987)
0d09de6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
c23b5ca Fix addToScene documentation (flutter/flutter#113987)
f22b4a8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
c23b5ca Fix addToScene documentation (flutter/flutter#113987)
cf3a3b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2022
@engine-flutter-autoroll
c23b5ca7d Fix addToScene documentation (flutter/flutter#113987)
a294e40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
c23b5ca Fix addToScene documentation (flutter/flutter#113987)
7868ceb
This was referenced Nov 3, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
c23b5ca7d Fix addToScene documentation (flutter/flutter#113987)
d82a02b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
c23b5ca Fix addToScene documentation (flutter/flutter#113987)
5ddda9a
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
Roll Flutter from 0e98194 to e6300da (46 revisions) (#6668)
8cfa265 
* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421)

* 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396)

* d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426)

* b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427)

* 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429)

* 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430)

* 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378)

* e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438)

* d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442)

* 93b0042 Handle dragging improvements (flutter/flutter#114042)

* dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444)

* 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449)

* eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228)

* fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998)

* e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003)

* c23b5ca Fix `addToScene` documentation (flutter/flutter#113987)

* 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830)

* 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076)

* 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453)

* f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464)

* 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079)

* 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471)

* 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476)

* dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479)

* 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480)

* b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487)

* 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489)

* 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492)

* 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439)

* dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494)

* 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501)

* 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264)

* db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513)

* 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451)

* 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793)

* 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527)

* 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369)

* 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532)

* 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533)

* 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458)

* 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534)

* 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466)

* b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540)

* 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537)

* 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546)

* e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 3, 2022
@engine-flutter-autoroll
Roll Flutter from 37beffe2a98b to e6300da2c39f (63 revisions) (#2776)
fd98a74 
* 4f19a9fa4 [flutter_tools] Add support for compiling shaders to JSON bundle for web (flutter/flutter#114295)

* f186e1bd3 Roll pub packages (flutter/flutter#114363)

* 0c7ee5869 Make `Linux_android  android_semantics_integration_test` flaky (flutter/flutter#114361)

* 7ab2bf8ff Delete flutter_migrate code (flutter/flutter#114253)

* 0d26c51e7 Roll Flutter Engine from e432d6fc3a9b to ef4acbfe67ac (2 revisions) (flutter/flutter#114367)

* af44c0599 Roll Flutter Engine from ef4acbfe67ac to 9ba3de8f078d (1 revision) (flutter/flutter#114368)

* 7979c8744 Roll Flutter Engine from 9ba3de8f078d to ef45b5ac5b4b (1 revision) (flutter/flutter#114370)

* c1a08463e Roll Flutter Engine from ef45b5ac5b4b to 96c0353790a2 (2 revisions) (flutter/flutter#114372)

* a75c1ff05 Roll Flutter Engine from 96c0353790a2 to 1a8ba7c5521a (1 revision) (flutter/flutter#114375)

* b20b7d995 Roll Flutter Engine from 1a8ba7c5521a to c16e2c08724c (1 revision) (flutter/flutter#114379)

* 37b72342b Add `maybeOf` for all the cases where `of` returns nullable. (flutter/flutter#114120)

* 6edbaa763 Roll Flutter Engine from c16e2c08724c to 034a2da497d9 (2 revisions) (flutter/flutter#114387)

* 4851401f0 Roll Flutter Engine from 034a2da497d9 to f721db653dd1 (1 revision) (flutter/flutter#114389)

* c2edb20f3 Added token files for badges and lists. (flutter/flutter#114382)

* 0f1d0e39e 🎨 Improve exceptions thrown by asset bundle (flutter/flutter#114313)

* 3894a069b Minor code cleanup: remove redundant return (flutter/flutter#114290)

* 0e9819468 Add Material 3 support for BottomAppBar (flutter/flutter#106525)

* 210a2aa37 Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421)

* 2bf666c17 Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396)

* d2ad439c0 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426)

* b03a7b5df Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427)

* 70a95d57c Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429)

* 0d65b630f Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430)

* 8a8b36177 Use hintText's TextStyle overflow (flutter/flutter#114378)

* e6b429694 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438)

* d0afbd72a Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442)

* 93b004255 Handle dragging improvements (flutter/flutter#114042)

* dc1cedd60 Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444)

* 8fe872877 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449)

* eadda3c39 Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228)

* fb9065fe0 `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998)

* e37ab48bc Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003)

* c23b5ca7d Fix `addToScene` documentation (flutter/flutter#113987)

* 61deaef5d Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830)

* 17ec3b1d1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076)

* 17df76ba8 Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453)

* f10021b37 Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464)

* 97d0247d5 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079)

* 0b0e348e0 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471)

* 6c87d7303 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476)

* dbc612380 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479)

* 4b3147386 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480)

* b2d9f9e16 Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487)

* 9d9b0e509 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489)

* 1a150ff46 Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492)

* 6a66aa282 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439)

* dca6f10a6 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494)

* 45c3b028c Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501)

* 9f2339173 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264)

* db381d75b Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513)

* 1cfdac4b2 Always invoke impeller ios shader target (flutter/flutter#114451)

* 0e70a97e2 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793)

* 1f7bacff4 Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527)

* 307987339 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369)

* 78dbe6661 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532)

* 3b0f8335e [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533)

* 0211df9cf [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458)

* 475ccd4ed Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534)

* 89418ef85 Added tokens for Snackbar widget. (flutter/flutter#114466)

* b23c7809f Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540)

* 15867a612 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537)

* 92a66683a Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546)

* e6300da2c [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)
IVLIVS-III pushed a commit to IVLIVS-III/flutter_plugins_fork that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll @IVLIVS-III
Roll Flutter from 0e98194 to e6300da (46 revisions) (flutter#6668)
20bd8f5 
* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421)

* 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396)

* d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426)

* b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427)

* 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429)

* 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430)

* 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378)

* e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438)

* d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442)

* 93b0042 Handle dragging improvements (flutter/flutter#114042)

* dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444)

* 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449)

* eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228)

* fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998)

* e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003)

* c23b5ca Fix `addToScene` documentation (flutter/flutter#113987)

* 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830)

* 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076)

* 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453)

* f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464)

* 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079)

* 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471)

* 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476)

* dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479)

* 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480)

* b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487)

* 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489)

* 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492)

* 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439)

* dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494)

* 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501)

* 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264)

* db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513)

* 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451)

* 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793)

* 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527)

* 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369)

* 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532)

* 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533)

* 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458)

* 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534)

* 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466)

* b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540)

* 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537)

* 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546)

* e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)
percula pushed a commit to percula/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll @percula
Roll Flutter from 37beffe2a98b to e6300da2c39f (63 revisions) (flutte…
1cd7167 
…r#2776)

* 4f19a9fa4 [flutter_tools] Add support for compiling shaders to JSON bundle for web (flutter/flutter#114295)

* f186e1bd3 Roll pub packages (flutter/flutter#114363)

* 0c7ee5869 Make `Linux_android  android_semantics_integration_test` flaky (flutter/flutter#114361)

* 7ab2bf8ff Delete flutter_migrate code (flutter/flutter#114253)

* 0d26c51e7 Roll Flutter Engine from e432d6fc3a9b to ef4acbfe67ac (2 revisions) (flutter/flutter#114367)

* af44c0599 Roll Flutter Engine from ef4acbfe67ac to 9ba3de8f078d (1 revision) (flutter/flutter#114368)

* 7979c8744 Roll Flutter Engine from 9ba3de8f078d to ef45b5ac5b4b (1 revision) (flutter/flutter#114370)

* c1a08463e Roll Flutter Engine from ef45b5ac5b4b to 96c0353790a2 (2 revisions) (flutter/flutter#114372)

* a75c1ff05 Roll Flutter Engine from 96c0353790a2 to 1a8ba7c5521a (1 revision) (flutter/flutter#114375)

* b20b7d995 Roll Flutter Engine from 1a8ba7c5521a to c16e2c08724c (1 revision) (flutter/flutter#114379)

* 37b72342b Add `maybeOf` for all the cases where `of` returns nullable. (flutter/flutter#114120)

* 6edbaa763 Roll Flutter Engine from c16e2c08724c to 034a2da497d9 (2 revisions) (flutter/flutter#114387)

* 4851401f0 Roll Flutter Engine from 034a2da497d9 to f721db653dd1 (1 revision) (flutter/flutter#114389)

* c2edb20f3 Added token files for badges and lists. (flutter/flutter#114382)

* 0f1d0e39e 🎨 Improve exceptions thrown by asset bundle (flutter/flutter#114313)

* 3894a069b Minor code cleanup: remove redundant return (flutter/flutter#114290)

* 0e9819468 Add Material 3 support for BottomAppBar (flutter/flutter#106525)

* 210a2aa37 Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421)

* 2bf666c17 Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396)

* d2ad439c0 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426)

* b03a7b5df Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427)

* 70a95d57c Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429)

* 0d65b630f Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430)

* 8a8b36177 Use hintText's TextStyle overflow (flutter/flutter#114378)

* e6b429694 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438)

* d0afbd72a Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442)

* 93b004255 Handle dragging improvements (flutter/flutter#114042)

* dc1cedd60 Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444)

* 8fe872877 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449)

* eadda3c39 Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228)

* fb9065fe0 `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998)

* e37ab48bc Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003)

* c23b5ca7d Fix `addToScene` documentation (flutter/flutter#113987)

* 61deaef5d Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830)

* 17ec3b1d1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076)

* 17df76ba8 Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453)

* f10021b37 Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464)

* 97d0247d5 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079)

* 0b0e348e0 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471)

* 6c87d7303 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476)

* dbc612380 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479)

* 4b3147386 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480)

* b2d9f9e16 Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487)

* 9d9b0e509 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489)

* 1a150ff46 Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492)

* 6a66aa282 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439)

* dca6f10a6 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494)

* 45c3b028c Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501)

* 9f2339173 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264)

* db381d75b Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513)

* 1cfdac4b2 Always invoke impeller ios shader target (flutter/flutter#114451)

* 0e70a97e2 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793)

* 1f7bacff4 Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527)

* 307987339 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369)

* 78dbe6661 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532)

* 3b0f8335e [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533)

* 0211df9cf [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458)

* 475ccd4ed Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534)

* 89418ef85 Added tokens for Snackbar widget. (flutter/flutter#114466)

* b23c7809f Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540)

* 15867a612 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537)

* 92a66683a Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546)

* e6300da2c [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll @adam-harwood
Roll Flutter from 0e98194 to e6300da (46 revisions) (flutter#6668)
46139c0 
* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421)

* 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396)

* d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426)

* b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427)

* 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429)

* 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430)

* 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378)

* e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438)

* d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442)

* 93b0042 Handle dragging improvements (flutter/flutter#114042)

* dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444)

* 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449)

* eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228)

* fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998)

* e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003)

* c23b5ca Fix `addToScene` documentation (flutter/flutter#113987)

* 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830)

* 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076)

* 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453)

* f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464)

* 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079)

* 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471)

* 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476)

* dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479)

* 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480)

* b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487)

* 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489)

* 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492)

* 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439)

* dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494)

* 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501)

* 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264)

* db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513)

* 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451)

* 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793)

* 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527)

* 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369)

* 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532)

* 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533)

* 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458)

* 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534)

* 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466)

* b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540)

* 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537)

* 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546)

* e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from 0e98194 to e6300da (46 revisions) (flutter#6668)
b058cdb 
* 210a2aa Revert "Add Material 3 support for BottomAppBar" (flutter/flutter#114421)

* 2bf666c Roll Flutter Engine from f721db653dd1 to 78ca5609d1cb (2 revisions) (flutter/flutter#114396)

* d2ad439 Roll Flutter Engine from 78ca5609d1cb to 31a21c75d016 (1 revision) (flutter/flutter#114426)

* b03a7b5 Roll Plugins from 91d7fe5 to 5c11747 (7 revisions) (flutter/flutter#114427)

* 70a95d5 Mark `Linux_android new_gallery__transition_perf` flaky (flutter/flutter#114429)

* 0d65b63 Roll Flutter Engine from 31a21c75d016 to e013908440cd (1 revision) (flutter/flutter#114430)

* 8a8b361 Use hintText's TextStyle overflow (flutter/flutter#114378)

* e6b4296 Roll Flutter Engine from e013908440cd to a98c82a5e583 (1 revision) (flutter/flutter#114438)

* d0afbd7 Revert "Overlay always applies clip (#113770)" (flutter/flutter#114442)

* 93b0042 Handle dragging improvements (flutter/flutter#114042)

* dc1cedd Roll Flutter Engine from a98c82a5e583 to c1e1a089fa16 (4 revisions) (flutter/flutter#114444)

* 8fe8728 Roll Flutter Engine from c1e1a089fa16 to f4da34f1f6a8 (4 revisions) (flutter/flutter#114449)

* eadda3c Add Material 3 Popup Menu example and update existing example (flutter/flutter#114228)

* fb9065f `Layer ... was previously used as oldLayer` assertion error in debug mode, and page being blank in release mode, caused by LeaderLayer addToScene bug (flutter/flutter#113998)

* e37ab48 Introduce debugWithActiveLayoutCleared to avoid duplicated code (flutter/flutter#114003)

* c23b5ca Fix `addToScene` documentation (flutter/flutter#113987)

* 61deaef Fix bug that`timeDilation` is not reset, causing subsequent test errors, and add verifications to ensure such problem does not exist in the future (flutter/flutter#113830)

* 17ec3b1 [flutter_tools] Introducing arg option for specifying the output directory for web (flutter/flutter#113076)

* 17df76b Roll Flutter Engine from f4da34f1f6a8 to e95a7ae83097 (1 revision) (flutter/flutter#114453)

* f10021b Roll Flutter Engine from e95a7ae83097 to 81f5c30b23f3 (6 revisions) (flutter/flutter#114464)

* 97d0247 Add Material 3 support for `Slider` - Part 1 (flutter/flutter#114079)

* 0b0e348 Roll Flutter Engine from 81f5c30b23f3 to 85c23bc12c56 (3 revisions) (flutter/flutter#114471)

* 6c87d73 Roll Flutter Engine from 85c23bc12c56 to c05c8a8834ca (1 revision) (flutter/flutter#114476)

* dbc6123 Roll Flutter Engine from c05c8a8834ca to 32faadb330fc (2 revisions) (flutter/flutter#114479)

* 4b31473 Roll Flutter Engine from 32faadb330fc to f9abfc5964c9 (1 revision) (flutter/flutter#114480)

* b2d9f9e Roll Flutter Engine from f9abfc5964c9 to 9a741295e793 (2 revisions) (flutter/flutter#114487)

* 9d9b0e5 Roll Flutter Engine from 9a741295e793 to 03d5b933164c (1 revision) (flutter/flutter#114489)

* 1a150ff Roll Flutter Engine from 03d5b933164c to 9ef5c9b0107b (2 revisions) (flutter/flutter#114492)

* 6a66aa2 Add Material 3 support for BottomAppBar (reland #106525) (flutter/flutter#114439)

* dca6f10 Roll Flutter Engine from 9ef5c9b0107b to f5eb26e3f763 (1 revision) (flutter/flutter#114494)

* 45c3b02 Roll Flutter Engine from f5eb26e3f763 to fed311918037 (2 revisions) (flutter/flutter#114501)

* 9f23391 [web] Changes to web keyboard selection shortcuts for more consistent behavior (flutter/flutter#114264)

* db381d7 Roll Flutter Engine from fed311918037 to cdfd9d0ad69b (2 revisions) (flutter/flutter#114513)

* 1cfdac4 Always invoke impeller ios shader target (flutter/flutter#114451)

* 0e70a97 Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (flutter/flutter#113793)

* 1f7bacf Marks Linux build_tests_2_3 to be unflaky (flutter/flutter#114527)

* 3079873 [flutter_tools/dap] Map org-dartlang-sdk URIs to the location of the source files found by the analyzer (flutter/flutter#114369)

* 78dbe66 Roll Flutter Engine from cdfd9d0ad69b to 4d1d7a41ebd2 (1 revision) (flutter/flutter#114532)

* 3b0f833 [flutter_tools/dap] Add a base Flutter adapter class to avoid duplication between adapters (flutter/flutter#114533)

* 0211df9 [flutter_tools] provide --timeout option to flutter drive (flutter/flutter#114458)

* 475ccd4 Roll Flutter Engine from 4d1d7a41ebd2 to edb049257b52 (2 revisions) (flutter/flutter#114534)

* 89418ef Added tokens for Snackbar widget. (flutter/flutter#114466)

* b23c780 Roll Flutter Engine from edb049257b52 to e43555ad3b94 (1 revision) (flutter/flutter#114540)

* 15867a6 Roll gallery to b6728704a6441ac37a21e433a1e43c990780d47b (flutter/flutter#114537)

* 92a6668 Roll Flutter Engine from e43555ad3b94 to 840a7b346216 (4 revisions) (flutter/flutter#114546)

* e6300da [tools]validation basic Xcode settings for build ipa (flutter/flutter#113412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fzyzcjy @goderbauer @justinmc