New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrectly named "debug" prefix #114117
Fix incorrectly named "debug" prefix #114117
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks reasonable, there are also some _debugReportException in framework.dart and layout_builder can you update those as well?
@chunhtai sure, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Please request a test exemption from @Hixie.
@cbracken done https://discord.com/channels/608014603317936148/608018585025118217/1035696084963577957 Btw, is it polite to ask for test exemption directly when creating this PR or I should wait for a few days? |
test-exemption: code refactor with no semantic change |
If you think the PR should be exempted, I don't think there is an inappropriate grace period to ask for NTE as far as I know. |
@chunhtai I see, thank you |
auto label is removed for flutter/flutter, pr: 114117, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Close #111874
Please read discussions there for why this PR is made :)
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.