Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly named "debug" prefix #114117

Merged
merged 4 commits into from Oct 31, 2022

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Oct 27, 2022

Close #111874

Please read discussions there for why this PR is made :)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 27, 2022
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks reasonable, there are also some _debugReportException in framework.dart and layout_builder can you update those as well?

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 28, 2022

@chunhtai sure, done

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Please request a test exemption from @Hixie.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 28, 2022

@cbracken done https://discord.com/channels/608014603317936148/608018585025118217/1035696084963577957

Btw, is it polite to ask for test exemption directly when creating this PR or I should wait for a few days?

@Hixie
Copy link
Contributor

Hixie commented Oct 28, 2022

test-exemption: code refactor with no semantic change

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 28, 2022
@chunhtai
Copy link
Contributor

Btw, is it polite to ask for test exemption directly when creating this PR or I should wait for a few days?

If you think the PR should be exempted, I don't think there is an inappropriate grace period to ask for NTE as far as I know.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Oct 28, 2022

@chunhtai I see, thank you

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 29, 2022

auto label is removed for flutter/flutter, pr: 114117, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
4 participants