Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nullable field in _HasWidgetLocation._location could be null #115582

Closed
christopherfujino opened this issue Nov 17, 2022 · 2 comments · Fixed by #120143
Closed

nullable field in _HasWidgetLocation._location could be null #115582

christopherfujino opened this issue Nov 17, 2022 · 2 comments · Fixed by #120143
Assignees
@christopherfujino
Labels
a: null-safety Support for the Dart's team new null safety feature f: inspector Part of widget inspector in framework. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list

Comments

@christopherfujino
Copy link
Member

Per discussion with @johnniwinther, the field _HasWidgetLocation._location which is marked non-nullable could be nullable, for example in the case where a tear-off constructor is used, the invocation point could not be determined: https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/widgets/widget_inspector.dart#L3245.

This field should be updated to be nullable.
@darshankawar darshankawar added in triage Presently being triaged by the triage team a: null-safety Support for the Dart's team new null safety feature framework flutter/packages/flutter repository. See also f: labels. f: inspector Part of widget inspector in framework. and removed in triage Presently being triaged by the triage team labels Nov 18, 2022
@goderbauer
Copy link
Member

cc @kenzieschmoll

@goderbauer goderbauer added the P2 Important issues not at the top of the work list label Nov 22, 2022
@christopherfujino christopherfujino self-assigned this Jan 10, 2023
@christopherfujino christopherfujino mentioned this issue Feb 7, 2023
Merged
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christopherfujino christopherfujino

Labels
a: null-safety Support for the Dart's team new null safety feature f: inspector Part of widget inspector in framework. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix widget inspector null check christopherfujino/flutter
3 participants
@goderbauer @christopherfujino @darshankawar