Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCI has introduced a new field in ScheduleBuildRequest that will be required in the future #116629

Open
nehalvpatel opened this issue Dec 7, 2022 · 4 comments
Assignees
Labels
P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team

Comments

@nehalvpatel
Copy link
Contributor

https://chromium.googlesource.com/infra/luci/luci-go/+/main/buildbucket/proto/builds_service.proto#456

// ...
//
// If schedule a build with parent, this field should be YES or NO.
// But UNSET is also accepted for now, and it has the same effect as YES.
// TODO(crbug.com/1031205): after the parent tracking feature is stable,
// require this field to be set when scheduling a build with parent.
Trinary can_outlive_parent = 21;

We should start setting this field. The LUCI team has said there is no concrete timeline to start rejecting UNSET.

@nehalvpatel nehalvpatel added team-infra Owned by Infrastructure team P1 High-priority issues at the top of the work list labels Dec 7, 2022
@ricardoamador ricardoamador self-assigned this Jun 21, 2023
@flutter-triage-bot
Copy link

This issue is assigned to @ricardoamador but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@flutter-triage-bot flutter-triage-bot bot added the Bot is counting down the days until it unassigns the issue label Nov 9, 2023
@ricardoamador
Copy link
Contributor

This is in progress right now. It is being done as part of an overall effort I am working on to use only buildbucket v2 apis and protos.

@ricardoamador ricardoamador removed the Bot is counting down the days until it unassigns the issue label Nov 9, 2023
@ricardoamador ricardoamador added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels Dec 14, 2023
@ricardoamador
Copy link
Contributor

Downgrading the priority as we will get this for free with the buildbucket client.

@ricardoamador
Copy link
Contributor

Schedule build request has been utilized though I am in the testing phase of bbv2 changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team
Projects
None yet
2 participants