New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autofill] TextInput.finishAutofillContext() doesn't bring up the system prompt #116889
Comments
Thanks for the report @lukaszdebowski RPReplay-Final1670915062.MP4In your video, I see that after inputing email and password each, you are tapping on |
Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. |
So you did exactly the thing I described as "iOS prompt to save the password appears after the password input loses the focus". The point of the bug is that the prompt should be shown upon calling |
Thanks for the update. stable, master flutter doctor -v
|
/cc @LongCatIsLooong |
After some survey of this issue, I discover once we using Doctor output[✓] Flutter (Channel stable, 3.7.6, on macOS 13.2.1 22D68 darwin-arm64, locale zh-Hant-TW)
• Flutter version 3.7.6 on channel stable at /Users/wunbinjhou/FlutterDevelopment/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 12cb4eb7a0 (2 months ago), 2023-03-01 10:29:26 -0800
• Engine revision ada363ee93
• Dart version 2.19.3
• DevTools version 2.20.1
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
• Android SDK at /Users/WunBinJhou/Library/Android/sdk
• Platform android-33, build-tools 33.0.0
• ANDROID_HOME = /Users/WunBinJhou/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14C18
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
[✓] HTTP Host Availability
• All required HTTP hosts are available |
Same problem here, on iOS the save prompt appears on focus lost and never when manually calling Has someone found a solution? |
Same issue here. Android works fine on both emulators & real devices. But iOS real device is not working |
@andynvt Kindly use github or anydomain for apple-app-site-association file. use this website for validating you file `{
} ` enable autofill by clicking on the capability |
I don't know if we have the exact same problem but in our application the question for saving login credentials always shows up after the login, so this might be related to the disposal of the text fields. Additonally we have the problem that the user credentials are saved but not reassociated to the text fields (This seems to be shown in the video but I'm not quite sure if this is the same problem) see #135948 |
This comment was marked as duplicate.
This comment was marked as duplicate.
@jsc57x I'm facing the same two issues on iOS that you described in your ticket. The request to save password is always presented (even though the credentials are already saved) and the user is forced to tap "Passwords" to manually select their credentials (it even shows unassociated domains). I'm using the developer alternative mode and have correctly hosted the associated domains file according to the documentation. |
is there any update about this? basically autofill is useless on ios if you are using different logic than "user will press the next/login button when finishing input without dismissing the keyboard". As soon as the keyboard is dismissed (user scrolls, taps somewhere etc), the prompt will show and we cannot control this at all. setting |
Can confirm that AutofillContextAction.cancel is not working at all, it just brings up the save password prompt when the autofillgroup is destroyed. |
Flutter 3.19.3 focus issue still ocuring: using code: Form(
key: _formKey,
child: AutofillGroup(
onDisposeAction: AutofillContextAction.cancel,
child: ... (TextField with AutofillHints.email and another for AutofillHints.password) Everytime when pressing on the background for unfocus after using the first TextField it triggers commit, but when using the second field after a unfocus event it stops doing it even if the button has "TextInput.finishAutofillContext();" action on it. Converted.mp4 |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Hi, On Android works perfectly, using finishAutofillContext or not. I have tried this in Flutter versions 3.13.8 and 3.19.5. I have tested my server app-site-association file with app-site-association test, and it returns the file correctly. |
Any updates? Can somebody fix it on iOS? |
Confirming this issue still exists in Flutter 3.19.6 on iOS 17.4.1 on multiple devices (physical and simulators). It also happens when the form loses focus. |
I do have the autofill service setup in my flutter app on iOS (including associated domains).
The api doesn't seem to work as it's explained in the docs. See below:
Steps to Reproduce
TextInput.finishAutofillContext()
Expected results:
iOS prompt to save the password should appear
Actual results:
iOS prompt to save the password appears after the password input loses the focus (i.e pressing the done button on the keyboard).
Pressing the "Next" button does not do anything.
Code sample
flutter doctor -v
See attached video (it shows another bug, which is the fact that the prompt did not show up at the first time at all)
output.mp4
App running on iOS 16.1.2
The text was updated successfully, but these errors were encountered: