Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When text is input in a text field, hint text should not be announced in talkback mode #117943

Closed
jiahaog opened this issue Jan 4, 2023 · 4 comments
Assignees
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) customer: money (g3) framework flutter/packages/flutter repository. See also f: labels. P0 Critical issues such as a build break or regression

Comments

@jiahaog
Copy link
Member

jiahaog commented Jan 4, 2023

Internal bug: b/264211793.

This issue is copied from the above bug, filed by customer: money.

Steps to Reproduce

Hint text is announced with no input:

5io7qmX9TUKai96

Hint text is announced with input:

64CemDjyawGhiTT

Expected results:

When text is input in a text field, hint text is not expected to be announced in talk back mode.

Actual results:

Hint text is announced in talk back mode

Code sample
Scaffold(
  appBar: AppBar(title: Text('Flutter Demo Home Page')),
  body: TextField(
    decoration: InputDecoration(hintText: 'Send a message...'),
  ),
)
@jiahaog
Copy link
Member Author

jiahaog commented Jan 4, 2023

This is a P2 because A11Y bugs are considered P1 internally by the customer, which maps to P2 on GitHub.

@Hixie Hixie added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jan 10, 2023
@hangyujin
Copy link
Contributor

hangyujin commented Jan 17, 2023

Related issue: #114511

We already excluded hint text semantics when text field has input and label text is provided. The reason we didn't exclude the hint text when text field has input and no label text is provided is that we think the hint text is likely the label.

@goderbauer Do you think we should exclude the hint text semantics when there is an input no matter if there is a label text or not?

@Hixie
Copy link
Contributor

Hixie commented Jan 24, 2023

FWIW I would recommend not trying to "do the right thing" in order to handle broken apps, just do the technically correct thing and let apps fail. Otherwise, what happens is that people start depending on the heuristics and then you quickly get to a place where the real API is the heuristics and they are hard to explain, hard to debug, and hard to use.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
@flutter-triage-bot flutter-triage-bot bot added P0 Critical issues such as a build break or regression and removed P2 labels Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) customer: money (g3) framework flutter/packages/flutter repository. See also f: labels. P0 Critical issues such as a build break or regression
Projects
None yet
Development

No branches or pull requests

3 participants