Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pigeon] Kotlin generator doesn't pass all integration tests #118726

Closed
stuartmorgan opened this issue Jan 18, 2023 · 2 comments · Fixed by flutter/packages#3155
Closed

[pigeon] Kotlin generator doesn't pass all integration tests #118726

stuartmorgan opened this issue Jan 18, 2023 · 2 comments · Fixed by flutter/packages#3155
Assignees
@tarrinneal
Labels
p: pigeon related to pigeon messaging codegen tool P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically

Comments

@stuartmorgan
Copy link
Contributor

stuartmorgan commented Jan 18, 2023 •
edited

While bringing up more integration tests, I had to exclude a few that failed or hung (a host-side exception?) for Kotlin; they are annotated with this bug number in integration_test.dart.

At least one of the int-related ones may be the same issue as #115914, so we should look at that issue when fixing this one (or the reverse).
@stuartmorgan stuartmorgan added p: first party package flutter/packages repository. See also p: labels. p: pigeon related to pigeon messaging codegen tool P2 Important issues not at the top of the work list labels Jan 18, 2023
@ycherniavskyi ycherniavskyi mentioned this issue Jan 19, 2023
Merged
11 tasks
@stuartmorgan
Copy link
Contributor Author

This was partly fixed by flutter/packages#3004

@stuartmorgan stuartmorgan added the platform-android Android applications specifically label Jan 27, 2023
@tarrinneal tarrinneal mentioned this issue Feb 2, 2023
Merged
@tarrinneal tarrinneal self-assigned this Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tarrinneal tarrinneal

Labels
p: pigeon related to pigeon messaging codegen tool P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pigeon] fix kotlin int errors tarrinneal/packages
2 participants
@stuartmorgan @tarrinneal