Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland the upload of win arm64 artifacts #118900

Closed
godofredoc opened this issue Jan 20, 2023 · 4 comments
Closed

Reland the upload of win arm64 artifacts #118900

godofredoc opened this issue Jan 20, 2023 · 4 comments
Assignees
@godofredoc
Labels
engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list platform-host-arm Building on an ARM-based platform platform-windows Building on or for Windows specifically
Projects
Engine V2 builders

Comments

@godofredoc
Copy link
Contributor

The original change was reverted in https://flutter-review.googlesource.com/c/recipes/+/38180.

The root cause of the problem is that the artifacts we were trying to upload didn't exist. They required additional ninja targets.

To prevent this from happening we need to add additional checks that the files exist on presubmit.
@godofredoc godofredoc self-assigned this Jan 20, 2023
@godofredoc
Copy link
Contributor Author

\cc @loic-sharma @zanderso @pbo-linaro

@godofredoc godofredoc added this to To do in Engine V2 builders via automation Jan 20, 2023
@darshankawar darshankawar added in triage Presently being triaged by the triage team engine flutter/engine repository. See also e: labels. platform-windows Building on or for Windows specifically platform-host-arm Building on an ARM-based platform and removed in triage Presently being triaged by the triage team labels Jan 23, 2023
@pbo-linaro
Copy link
Contributor

Do you need help on fixing this? In the original patch, it was just doing the same thing as the x64 platform, so I don't have a clue about what could be missing.

@chinmaygarde chinmaygarde added the P1 High-priority issues at the top of the work list label Jan 23, 2023
@godofredoc
Copy link
Contributor Author

Fixed with: https://flutter-review.googlesource.com/c/recipes/+/38132

Engine V2 builders automation moved this from To do to Done Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@godofredoc godofredoc

Labels
engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list platform-host-arm Building on an ARM-based platform platform-windows Building on or for Windows specifically
Projects
Engine V2 builders
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chinmaygarde @godofredoc @darshankawar @pbo-linaro