Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine -> Framework roll failing on missing artifacts #119069

Closed
zanderso opened this issue Jan 24, 2023 · 11 comments
Closed

Engine -> Framework roll failing on missing artifacts #119069

zanderso opened this issue Jan 24, 2023 · 11 comments
Assignees
Labels
P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team

Comments

@zanderso
Copy link
Member

See the roll here #119067 failing due to:

Failed to download https://storage.googleapis.com/flutter_infra_release/flutter/7f38d0d4f5c2538295f3bbbc42e15ad75b191ae1/windows-x64/windows-x64-flutter.zip. Ensure you have network connectivity and then try again.
           Exception: 404

The changes to Windows artifact locations/paths needs a soft transition in the Flutter tool. (Or don't change the locations.)

@zanderso zanderso added team-infra Owned by Infrastructure team P0 Critical issues such as a build break or regression labels Jan 24, 2023
@zanderso zanderso added this to New in Infra Ticket Queue via automation Jan 24, 2023
@zanderso
Copy link
Member Author

cc @christopherfujino

@zanderso
Copy link
Member Author

zanderso commented Jan 24, 2023

I reverted the recipe change here https://flutter-review.git.corp.google.com/c/recipes/+/38240. Leaving as P0 until there is a successful Engine -> Framework roll.

@zanderso
Copy link
Member Author

Keeping an eye on this roll #119070, which I think started after the recipe revert.

@christopherfujino
Copy link
Member

cc @christopherfujino

thanks!

@zanderso
Copy link
Member Author

The roll is still failing. We will need a commit to the engine repo to trigger building and uploading new Windows artifacts following the recipe revert.

@godofredoc
Copy link
Contributor

The tool expects the file to be in 7f38d0d4f5c2538295f3bbbc42e15ad75b191ae1/windows-x64/windows-x64-flutter.zip and it was uploaded to 7f38d0d4f5c2538295f3bbbc42e15ad75b191ae1/windows-x64-debug/windows-x64-flutter.zip

@godofredoc
Copy link
Contributor

I see what the issue is, I removed:

-    # Legacy; remove once Flutter tooling is updated to use the -debug location.
-    PackageWindowsDesktopVariant(api, 'host_debug', 'windows-x64')

Adding it back and ensure that tool is migrated to the debug location.

@ricardoamador
Copy link
Contributor

Thank you @godofredoc!

@godofredoc
Copy link
Contributor

@zanderso
Copy link
Member Author

An engine roll landed, so I'll close this. We can follow up on the recipe reland with a separate issue or PR.

Infra Ticket Queue automation moved this from Triaged to Done Jan 24, 2023
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team
Projects
No open projects
Development

No branches or pull requests

5 participants