Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ColorScheme.fromSwatch #120064

Open
guidezpl opened this issue Feb 6, 2023 · 3 comments
Open

Deprecate ColorScheme.fromSwatch #120064

guidezpl opened this issue Feb 6, 2023 · 3 comments
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@guidezpl
Copy link
Member

guidezpl commented Feb 6, 2023 •
edited by TahaTesser

This constructor carries over numerous M2 defaults, leads to issues like an inconsistent experience. We should replace with ColorScheme.fromSeed.

Related issues

#91772
#112811
#86341
#90637
#127992
@guidezpl guidezpl added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 6, 2023
@guidezpl guidezpl mentioned this issue Feb 6, 2023
Closed
@Bungeefan Bungeefan mentioned this issue Apr 13, 2023
Closed
@TahaTesser TahaTesser mentioned this issue Jun 1, 2023
Closed
@TahaTesser
Copy link
Member

@guidezpl
Added #127992 to the related issues list.

@guidezpl guidezpl mentioned this issue Jun 3, 2023
Open
40 tasks
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-design Owned by Design Languages team triaged-design Triaged by Design Languages team labels Jul 8, 2023
@TahaTesser
Copy link
Member

@guidezpl
Should this issue also track deprecation of ColorScheme.light and ColorScheme.dark. These currently generate a M2 color scheme using a purple primary and shouldn't be used with Material 3.

@guidezpl
Copy link
Member Author

guidezpl commented Nov 7, 2023

Worth a separate issue, I'd say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hixie @guidezpl @TahaTesser