Recipe led tests are picking up release candidate branch runs

[godofredoc]

Recipe led tests should be using main recipes.

Run:
https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/flutter-try-builder_chops-service-accounts.iam.gserviceaccount.com/3f4abbc5ad760beeeb355cc19253868bf6ce986705a127c5a1de41bf74f53fbb/+/build.proto?server=chromium-swarm.appspot.com

[drewroengoogle]

@godofredoc What command(s) did you use to run this? Anything ususual outside of the regular led get-builder?

[godofredoc]

This was triggered by led recipe testing:

• https://cs.opensource.google/flutter/recipes/+/main:recipes/recipes.py
• https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/recipe_testing/

[drewroengoogle]

Ah, so this is run on any recipes CL?

[godofredoc]

Ah, so this is run on any recipes CL?

Yes, that is correct.

[drewroengoogle]

To summarize the problem - When opening a CL for recipes, the presubmit will look for any modified recipes, take the last green build, and replicate it using the modified recipe to make sure it is still passing. However, in some cases, the last green build is not on the same branch as the recipes CL is merging into, causing problems. In the case above, the last green build was on flutter-3.7-candidate.1, not main/master.

We need to change the testing to search for the last green build that is on the same branch as the CL is merging into.

EDIT: Related build (so I don't have to search for it again): https://ci.chromium.org/p/flutter/builders/try/recipes-with-led/b8789786742166096689

[ricardoamador]

Related: #120287

[drewroengoogle]

Finishing up a CL for this: need to write tests

[drewroengoogle]

https://flutter-review.googlesource.com/c/recipes/+/39181

[drewroengoogle]

^ This has been merged!

[drewroengoogle]

Closing, feel free to reopen

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.