Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_adaptive_scaffold] : selectedIcon allowed in NavigationDestination but not able to render. #121135

Closed
aliasgar4558 opened this issue Feb 21, 2023 · 4 comments
Closed

[flutter_adaptive_scaffold] : selectedIcon allowed in NavigationDestination but not able to render. #121135

aliasgar4558 opened this issue Feb 21, 2023 · 4 comments
Labels
found in release: 3.7 Found to occur in 3.7 has reproducible steps The issue has been confirmed reproducible and is ready to work on p: flutter_adaptive_scaffold The flutter_adaptive_scaffold package P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. r: fixed Issue is closed as already fixed in a newer version

Comments

@aliasgar4558
Copy link
Contributor

Use case

NavigationDestination has an option to add selectedIcon which shall display when user selects that specific destination/navigation. However, it is not been able to display even if the destination is selected.

Proposal

SelectedIcon needs to be given toBottomNavigationBarItem in adaptive_scaffold.dart which shall resolve the problem.
@aliasgar4558 aliasgar4558 changed the title selectedIcon allowed in NavigationDestination but not able to render. [flutter_adaptive_scaffold] : selectedIcon allowed in NavigationDestination but not able to render. Feb 21, 2023
@exaby73 exaby73 added the in triage Presently being triaged by the triage team label Feb 22, 2023
@exaby73
Copy link
Member

exaby73 commented Feb 22, 2023

Hello @aliasgar4558. Thank you for filing this issue. Can you please provide the following information?

Please provide the information in the form of text. See how to make collapsible sections with Markdown here.

@exaby73 exaby73 added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Feb 22, 2023
@aliasgar4558 aliasgar4558 mentioned this issue Feb 22, 2023
Merged
11 tasks
@aliasgar4558
Copy link
Contributor Author

hey @exaby73 , Thanks for taking interest in the issue. I have implement a fix in for the same issue which I reported. Merge request is also been raised for the same [https://github.com/flutter/packages/pull/3253]. Please do have a look at that once.

@github-actions github-actions bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Feb 23, 2023
@exaby73 exaby73 added package flutter/packages repository. See also p: labels. has reproducible steps The issue has been confirmed reproducible and is ready to work on p: flutter_adaptive_scaffold The flutter_adaptive_scaffold package found in release: 3.7 Found to occur in 3.7 and removed in triage Presently being triaged by the triage team labels Feb 23, 2023
@stuartmorgan stuartmorgan added the P2 Important issues not at the top of the work list label Feb 28, 2023
@aliasgar4558
Copy link
Contributor Author

Hurrrayyyyy.....Closed this issue as the fix is been merged into main as version 0.1.1.
Thanks..

@exaby73 exaby73 added the r: fixed Issue is closed as already fixed in a newer version label Mar 20, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
found in release: 3.7 Found to occur in 3.7 has reproducible steps The issue has been confirmed reproducible and is ready to work on p: flutter_adaptive_scaffold The flutter_adaptive_scaffold package P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. r: fixed Issue is closed as already fixed in a newer version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stuartmorgan @aliasgar4558 @exaby73