[cherry pick] Fix field cleared by TestWindow.clearGestureSettingsTestValue #123044
Conversation
flutter-dashboard
bot
added
a: tests
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
rerunning "Linux firebase_android..." and "mac module_test" to deflake |
|
will merge since this is approved in #123053 (comment) |
XilaiZhang
merged commit ebc5079
into
flutter:flutter-3.9-candidate.1
|
LGTM. In the future, please don't submit without a human approver |
|
Umm should we ask reviewer to approve in the issue as well? I thought this one was approved by Godofredo in the pr link
|
|
This PR currently has no approvers outside the bot (and my comment). See attached. You need to have approvers on the issue and PR. |
context: https://chat.google.com/room/AAAAc_4rqiI/5ID913zNyOU
we are seeing test failures on beta branches. And it seems like the cp in (#121956) would fix it