Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Umbrella issue for Material2 API doc updates #127216

Closed
11 tasks done
Tracked by #91605
leighajarett opened this issue May 19, 2023 · 10 comments
Closed
11 tasks done
Tracked by #91605

☂️ Umbrella issue for Material2 API doc updates #127216

leighajarett opened this issue May 19, 2023 · 10 comments
Labels
c: proposal A detailed proposal for a change to Flutter d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@leighajarett
Copy link
Contributor

leighajarett commented May 19, 2023

Is there an existing issue for this?

Use case

As we prepare to make Material 3 the default, we should make it clear that while Material 2 widgets will continue to exist, some have Material 3 counterparts that may be more useful and better match Material 3 app styles.

Proposal

There are a few Material 2 widgets whose API docs need to be updated:

M2 widget M3 widget Tracking issue / PR
ToggleButtons SegmentedButtons
BottomNavigationBar NavigationBar
Drawer NavigationDrawer
DropdownButton DropDownMenu
PopupMenuButton MenuAnchor
MaterialColor ColorScheme
ButtonBar OverflowBar
ActionChip Showcase suggest and assist
ThemeData List out the properties that should be used for Material3
@leighajarett leighajarett added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels May 19, 2023
@leighajarett leighajarett self-assigned this May 19, 2023
@HansMuller HansMuller changed the title Umbrella issue for Material2 API doc updates ☂️ Umbrella issue for Material2 API doc updates May 23, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2023
@leighajarett leighajarett reopened this Jul 19, 2023
@guidezpl
Copy link
Member

Great list, thank you.

I would also add ColorScheme.fromSwatchColorScheme.fromSeed and ColorScheme.fromImageProvider

For posterity, there are also:

  • new constructors: IconButton.filled, IconButton.filledTonal, and IconButton.outlined, TabBar.secondary,
  • new top-level widgets: SearchBar and SearchAnchor

But I think these are well enough documented among themselves.

@flutter-triage-bot flutter-triage-bot bot unlocked this conversation Jul 22, 2023
@HansMuller
Copy link
Contributor

We should also provide a way to issue runtime advice about M2-M3 migration, see #130932 (comment)

@flutter-triage-bot flutter-triage-bot bot added the Bot is counting down the days until it unassigns the issue label Feb 7, 2024
@flutter-triage-bot
Copy link

This issue is assigned to @leighajarett but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@flutter-triage-bot
Copy link

This issue was assigned to @leighajarett but has had no status updates in a long time. To remove any ambiguity about whether the issue is being worked on, the assignee was removed.

@flutter-triage-bot flutter-triage-bot bot removed the Bot is counting down the days until it unassigns the issue label Feb 15, 2024
@huycozy huycozy added in triage Presently being triaged by the triage team d: api docs Issues with https://api.flutter.dev/ c: proposal A detailed proposal for a change to Flutter team-design Owned by Design Languages team and removed in triage Presently being triaged by the triage team labels Feb 16, 2024
@HansMuller HansMuller added P2 Important issues not at the top of the work list triaged-design Triaged by Design Languages team labels Feb 28, 2024
@HansMuller
Copy link
Contributor

@TahaTesser, @Piinks - I think that you-all have resolved the final unchecked issue on this one.

@TahaTesser
Copy link
Member

TahaTesser commented Feb 28, 2024

@TahaTesser, @Piinks - I think that you-all have resolved the final unchecked issue on this one.

I think so, checking the issue i don't see any immediate actionable item.

The text theme can be automatically fixed for M3 using dart fix --apply, this replaces the deprecated text theme props.

Screenshot 2024-02-28 at 20 48 06

As for other theme data props, we have #91772 which lists deprecated/to be deprecated props which are ineffective for Material 3 widgets and some Material 2 widgets too.

@Piinks
Copy link
Contributor

Piinks commented Feb 28, 2024

Thanks for taking a look @TahaTesser! I concur, should we close this then and follow up in #91772?

@TahaTesser
Copy link
Member

@TahaTesser, @Piinks - I think that you-all have resolved the final unchecked issue on this one.

Closed the final unchecked issue. With that, this issue can be closed.

@TahaTesser TahaTesser added the r: fixed Issue is closed as already fixed in a newer version label Feb 29, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: proposal A detailed proposal for a change to Flutter d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list r: fixed Issue is closed as already fixed in a newer version team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Development

No branches or pull requests

6 participants