-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VirtualDisplay option for AndroidView. #130692
Comments
What's the use case here? The only reason VD still exists is for very specific edge cases; if there's another compelling reason to use it we need to know what that is. |
I don't know all the cases but I can imagine some cases related to bugs/limitations of HCTL like:
VD mode uses other approaches so It has different pros and cons, if plugins do not meet its bugs, why don't let them use it. |
I am not asking for all cases or imaginary cases, I'm asking for your specific motivating case so that we can evaluate if this is the best option for addressing it.
That's tracked in #109690; we're still evaluating whether we can detect that dynamically. (There's also a simple workaround in the meantime.)
This is very vague; are you referring to #103686 ? Similarly, that's still being investigated. If it's not solvable, the right approach would be to automatically opt
Could you provide a link for this please?
As we've explained several times in your other issues and design document about platform views: permanently maintaining lots of modes, and having a complex API surface that makes plugin developers choose between a confusing array of options, are anti-goals for the Flutter team. Our goal is to, as much as possible, simplify the platform view system. |
If you are done with the asking let's talk about why you don't think this is not necessary. |
I have explained why our default position is to not add it; the onus is on the proposal to justify that there is a compelling need that makes it necessary to add despite that. The three issues above are not currently sufficient justification, for the reasons I outlined above. |
I'm not looking to solve any issue that you asked me to provide.
Are 3 modes a lot?
Spending a few minutes to read the doc of a param won't hurt. The point is what it does, If dev can make use of it, it has a purpose. Chart libraries have hundreds of options, why dev doesn't complain to reduce the options?
I don't think all dev is that lazy and needs your goal Anyway, I've explained my proposal. About the use case, let's just say I cannot provide a convincing one but thousands of plugins out there may use this option for their own purpose. |
Hi @XuanTung95 thanks for your request. Our goals for Android Platform Views is to reduce the API surface area but only when we can guarantee good behaviour of any android.view.View hierarchy. We would like to automatically switch to VirtualDisplay mode when necessary (by observing the view hierarchy changes) so that application authors don't need to worry about it. |
FYI- I hope to have an update on this issue sometime in September. |
In my opinion I would prefer to have a unified API and rendering logic, as the current issue is that different versions of the Flutter SDK may use different behaviors for the same API. Since we cannot achieve unified rendering logic, it would be better to open it to developers for configuration. Currently, it is neither unified nor controllable, and it is difficult to expect results. |
@CarGuo I am not convinced that we can't achieve a unified API and I hope to deliver one this year. If we cannot achieve it or the amount of work required to achieve it is too high, I agree we should give more explicit controls to developers so they can decide between the implementations. |
This issue is assigned to @johnmccutchan but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks! |
This issue was assigned to @johnmccutchan but has had no status updates in a long time. To remove any ambiguity about whether the issue is being worked on, the assignee was removed. |
@johnmccutchan can this be closed now? |
Current status:
Letting users explicitly pick a mode is problematic, if we had an API that said "Use VirtualDisplay" apps would break on newer versions of Android. Closing this issue as we need to investigate an alternative to VirtualDisplay mode entirely. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Is there an existing issue for this?
Use case
Proposal
The text was updated successfully, but these errors were encountered: