[CP] Update vm_snapshot_analysis to 0.7.6

[sstrickl]

Issue Link

#132695

Commit Hash

3b8f6c4

Target

stable

PR Link

#133657

Changelog Description

Build fails when using the --analyze-size argument.

Impacted Users

All Flutter developers

Impact Description

When using the --analyze-size argument, builds fail with a crash in package:vm_snapshot_analysis/v8_profile.dart.

Workaround

Manually updating the flutter package dependencies or using the beta branch.

Risk

low

Test Coverage

yes

Validation Steps

No response

[sstrickl]

Note that this isn't a direct cherry-pick of 3b8f6c4, but only updates the pinned vm_snapshot_analysis version.

[itsjustkevin]

@sstrickl is there any reason why we wouldn’t pick the entire change?

Have we tested this cherry-pick with the full DEPS roll?

Reaching out to @christopherfujino for initial review.

[sstrickl]

The only reason I didn't just cherry pick 3b8f6c4 was just trying to limit the amount of package changes hitting stable, when only the one for vm_snapshot_analysis is needed to fix the issue linked above. However, that change landed the day after stable was forked, so I would be surprised if it actually caused any issues. I'm happy to change the PR to just cherry pick that change wholesale instead if that would be preferred.

[itsjustkevin]

Thanks for explaining @sstrickl! We already cut for the next release, so we have time to work though the pros and cons of each approach 🙂.

[christopherfujino]

The only reason I didn't just cherry pick 3b8f6c4 was just trying to limit the amount of package changes hitting stable, when only the one for vm_snapshot_analysis is needed to fix the issue linked above. However, that change landed the day after stable was forked, so I would be surprised if it actually caused any issues. I'm happy to change the PR to just cherry pick that change wholesale instead if that would be preferred.

@sstrickl I think you did the right thing. Also, I love your avatar. @itsjustkevin I'll add an action item for our next 1:1 to discuss codifying exactly how to handle these situations.

[christopherfujino]

@itsjustkevin I think this slipped through the cracks and was missed for the 3.13.3 stable release.

[itsjustkevin]

@christopherfujino and @sstrickl this did slip through and that is 100% on me. So we are aligned on submitting the cherry-pick as is?

[sstrickl]

Yep, sounds like it :)

[christopherfujino]

@christopherfujino and @sstrickl this did slip through and that is 100% on me. So we are aligned on submitting the cherry-pick as is?

Yes, looks good to go

[itsjustkevin]

Closing this once it is released.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.