Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Re-enable safari tests that utilize InputEvent.inputType #134271

Open
Renzo-Olivares opened this issue Sep 8, 2023 · 0 comments
Open

[Web] Re-enable safari tests that utilize InputEvent.inputType #134271

Renzo-Olivares opened this issue Sep 8, 2023 · 0 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems browser: safari-macos only manifests in Safari on macOS engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically team: skip-test An issue used to track tests that are skipped. team-web Owned by Web platform team triaged-web Triaged by Web platform team

Comments

@Renzo-Olivares
Copy link
Contributor

Renzo-Olivares commented Sep 8, 2023 •
edited

Some tests that utilize InputEvent.inputType have been skipped on Safari. Safari only recently added support for setting inputType on Safari 16, more context on this issue here . The CI is currently running on the tests on Safari 15 so tests fail. These tests should be re-enabled when the CI is rolled to Safari 16.

affected files: text_editing_test.dart
tests: Supports deletion at inverted selection, Supports new line at inverted selection.

PR that introduces tests: flutter/engine#44693
@Renzo-Olivares Renzo-Olivares changed the title Re-enable safari tests that utilize InputEvent.inputType [Web] Re-enable safari tests that utilize InputEvent.inputType Sep 8, 2023
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. platform-web Web applications specifically browser: safari-macos only manifests in Safari on macOS team-web Owned by Web platform team and removed in triage Presently being triaged by the triage team labels Sep 8, 2023
@Renzo-Olivares Renzo-Olivares mentioned this issue Sep 8, 2023
Merged
8 tasks
@yjbanov yjbanov added team: skip-test An issue used to track tests that are skipped. P2 Important issues not at the top of the work list triaged-web Triaged by Web platform team labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems browser: safari-macos only manifests in Safari on macOS engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically team: skip-test An issue used to track tests that are skipped. team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yjbanov @Renzo-Olivares @danagbemava-nc