Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] Attempt enabling validations by default in all debug Vulkan builds. #134679

Closed
chinmaygarde opened this issue Sep 13, 2023 · 5 comments
Assignees
Labels
e: impeller Impeller rendering backend issues and features requests P1 High-priority issues at the top of the work list team-engine Owned by Engine team

Comments

@chinmaygarde
Copy link
Member

Today, validations need to be enabled explicitly via flags. This was because locating the validation layers was platform specific and asking for validations and not finding the layers was a fatal error.

We are now packaging our own validation layers and also not failing Vulkan context creation when the layer could not be found.

Impeller should attempt loading validations in debug runtime modes by default now.

@chinmaygarde chinmaygarde added e: impeller Impeller rendering backend issues and features requests team-engine Owned by Engine team labels Sep 13, 2023
@matanlurey matanlurey self-assigned this Sep 16, 2023
@chinmaygarde chinmaygarde added the P1 High-priority issues at the top of the work list label Sep 18, 2023
@chinmaygarde
Copy link
Member Author

This is apparently already done 🎉.

@matanlurey
Copy link
Contributor

I don't see it?

In @gaaclarke's flutter/engine#45682, we appear to enable for ARM64 builds only. Is that "all debug Vulkan builds", or am I missing something?

@matanlurey matanlurey reopened this Sep 18, 2023
@gaaclarke
Copy link
Member

@matanlurey this was discussed in the PR review that arm64 is sufficient. I believe it captures 93% of android phones. I don't think we could get arm32 working, but we could get x64 if we wanted. I think that's what you were running into the other day. I'd file that as a separate issue considering it has a different priority.

@matanlurey
Copy link
Contributor

Gotcha, then let's close this, thanks for clarifying!

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: impeller Impeller rendering backend issues and features requests P1 High-priority issues at the top of the work list team-engine Owned by Engine team
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants