Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move create_updated_flutter_deps.py out of the buildroot. #137084

Open
chinmaygarde opened this issue Oct 23, 2023 · 4 comments
Open

Move create_updated_flutter_deps.py out of the buildroot. #137084

chinmaygarde opened this issue Oct 23, 2023 · 4 comments
Labels
c: tech-debt Technical debt, code quality, testing, etc. P2 Important issues not at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@chinmaygarde
Copy link
Member

The buildroot is being merged into the engine. This will cause files and directories to be shuffled. That in itself is usually not a concern as accompanying changes to the build rules will account for these changes.

However, some files like create_update_flutter_deps.py are used by CI jobs and autorollers. It is hard to tell who uses such scripts, if the location of the scripts is relevant, and if the scripts can be tested.

This issue tracks moving the scripts the the repos that use them.

@chinmaygarde
Copy link
Member Author

cc @zanderso @matanlurey @cbracken

@chinmaygarde chinmaygarde added c: tech-debt Technical debt, code quality, testing, etc. team-engine Owned by Engine team labels Oct 23, 2023
@zanderso
Copy link
Member

Maybe @aam or @whesse might be able to help remember where references to this script come from?

@chinmaygarde
Copy link
Member Author

Do you remember if it was just one autoroller?

@zanderso zanderso added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. P2 Important issues not at the top of the work list triaged-engine Triaged by Engine team labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: tech-debt Technical debt, code quality, testing, etc. P2 Important issues not at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Development

No branches or pull requests

3 participants