Recipes don't wait for simulator runtimes to be unmounted

[vashworth]

Is there an existing issue for this?

• I have searched the existing infra issues

Type of Request

bug

Infrastructure Environment

Recipes

What is happening?

In recipes, when the Xcode cache is cleared, we unmount all runtimes. Afterward, we will reinstall and remount the needed runtimes. Before remounting, though, we check to see if it need to be remounted.

It seems that the command to unmount runtimes (xcrun simctl runtime delete all) does not wait for it complete, which may cause issues like the example below:

For example: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/477518/overview
In step 20.2, the runtimes are unmounted
In step 21.2, we can see the unmounted hasn't finished though because the runtimes are still available
Also, there are no verify and mount runtime substeps in 21, which means it thought the runtimes were still mounted (https://flutter.googlesource.com/recipes/+/refs/heads/main/recipe_modules/osx_sdk/api.py#340)

Steps to reproduce

Unfortunately this does not happen every time since it's a race condition

Expected results

I expect runtimes to be remounted if applicable after unmounting.

[vashworth]

Should be fixed with https://flutter-review.googlesource.com/c/recipes/+/52041.

[vashworth]

Looks like problem is still happening: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/507815/overview

If I look at the next task on the same bot, it shows the runtime were removed: https://luci-milo.appspot.com/ui/p/flutter/builders/try/Mac%20module_test/35445/overview

[vashworth]

I increased the amount of time it can wait up to and that seems to have fixed:
https://flutter-review.googlesource.com/c/recipes/+/52441
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/510221/overview

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.