Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta release 3.17.0-0.1.pre wrong tagging #139311

Closed
Jasguerrero opened this issue Nov 30, 2023 · 2 comments
Closed

Beta release 3.17.0-0.1.pre wrong tagging #139311

Jasguerrero opened this issue Nov 30, 2023 · 2 comments
Assignees
Labels
team-release Owned by Release team

Comments

@Jasguerrero
Copy link
Contributor

Jasguerrero commented Nov 30, 2023

After releasing 3.17.0-0.1.pre beta, despite putting the new tag as 0.1.pre in the sdk archive it shows as 3.17.0-0.0.pre and now we have 2 betas with the same tag.

The issue appears to be today's tagging step instead of tagging at the HEAD, tagged at the base commit before branching which was 0b591f2. Packaging seems to have done the right thing which is get the first tag for that commit.

@Jasguerrero Jasguerrero added the team-release Owned by Release team label Nov 30, 2023
@CaseyHillers
Copy link
Contributor

The culprit builder is https://luci-milo.appspot.com/ui/p/dart-internal/builders/flutter/Linux%20flutter_release/51/overview

The interesting aspect is the parameters for tagging appear to be correct:

  RELEASE_CHANNEL: beta
  REL_HASH: 12b47270b7a705f4dc7fe7a899acc2f7b5fdb63b
##### TAGGING #####
fatal: tag '3.17.0-0.1.pre' already exists
Everything up-to-date

It looks like we wanted to ship 3.17.0-0.2.pre instead of .1. The larger bug is it shipped the entire Flutter RC branch to beta instead of the tagged part.

I sent https://flutter-review.googlesource.com/c/recipes/+/52800 which should fix the issue. This should have stopped the release at the failed tagging command.

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-release Owned by Release team
Projects
None yet
Development

No branches or pull requests

2 participants