Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra + release] Mac engine release builder failing on Impeller-golden #144704

Closed
XilaiZhang opened this issue Mar 6, 2024 · 3 comments
Closed

[infra + release] Mac engine release builder failing on Impeller-golden #144704

XilaiZhang opened this issue Mar 6, 2024 · 3 comments
Labels
P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team

Comments

@XilaiZhang
Copy link
Contributor

sample failure: https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20engine_release_builder/524/overview

This fails on mac engine release builders and could affect future releases
@XilaiZhang XilaiZhang added team-infra Owned by Infrastructure team P1 High-priority issues at the top of the work list P0 Critical issues such as a build break or regression and removed P1 High-priority issues at the top of the work list labels Mar 6, 2024
@XilaiZhang XilaiZhang mentioned this issue Mar 6, 2024
Closed
@keyonghan
Copy link
Contributor

keyonghan commented Mar 6, 2024 •
edited
Loading

Requested gold storage access for the release account to unblock. (waiting for approval).

The golden tests should be skipped from release targets instead.

@zanderso zanderso mentioned this issue Mar 7, 2024
Closed
@keyonghan
Copy link
Contributor

Test has been separated to skip from release branches (also CP'ed).
flutter/engine#51240
flutter/engine#51255

@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P0 Critical issues such as a build break or regression team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XilaiZhang @keyonghan