-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigeon] constant_identifier_names
lint complains on generated code
#145633
Comments
I was able to replicate this using provided details. stable, master flutter doctor -v
|
This comment was marked as outdated.
This comment was marked as outdated.
Hello, I'm new to open source and want to contribute to this project. So, can you point me in the right direction? |
This issue is missing a priority label. Please set a priority label when adding the |
@stuartmorgan should our analyzer/linter catch this? It's hard for me to know each issue that could come up when we aren't checking for them. |
I think it would be reasonable to have a test that runs generated code through analysis using the |
Steps to reproduce
Write a pigeon with a method:
Then run Pigeon, and run the analyzer on the output.
Expected results
There should be no lint warnings.
Actual results
The
constant_identifier_names
lint reports an issue:The generated code in question looks like:
It's fine that the code looks like that. But then
constant_identifier_names
should just get included in the bigignore_for_file:
line at the top.Dependency versions
pubspec.lock
The text was updated successfully, but these errors were encountered: