Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvaskit datepicker skiagold tests are flaky #110785

Open
zanderso opened this issue Sep 1, 2022 · 9 comments
Open

Canvaskit datepicker skiagold tests are flaky #110785

zanderso opened this issue Sep 1, 2022 · 9 comments
Assignees
Labels
customer: huggsy (g3) dependency: skia Skia team may need to help us P1 High-priority issues at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team

Comments

@zanderso
Copy link
Member

zanderso commented Sep 1, 2022

Internal: b/292548039

Since the most recent canvaskit roll, these tests are producing new skia diffs on nearly every run. This is closing the framework tree, and blocking rolls.

cc @yjbanov

@zanderso zanderso added platform-web Web applications specifically P0 Critical issues such as a build break or regression labels Sep 1, 2022
@zanderso
Copy link
Member Author

zanderso commented Sep 1, 2022

In particular, at least the following appear to be producing inconsistent results across runs:

cupertino.date_picker_test.datetime.initial
cupertino.date_picker_test.time.initial
cupertino.date_picker_test.datetime.drag

@yjbanov yjbanov self-assigned this Sep 1, 2022
@yjbanov yjbanov added P2 and removed P0 Critical issues such as a build break or regression labels Sep 1, 2022
@yjbanov
Copy link
Contributor

yjbanov commented Sep 1, 2022

Since the CanvasKit roll was reverted, dropping priority to P2.

@yjbanov yjbanov added the dependency: skia Skia team may need to help us label Sep 1, 2022
@yjbanov
Copy link
Contributor

yjbanov commented Sep 7, 2022

Update: still discussing what the right solution is here.

@Hixie
Copy link
Contributor

Hixie commented Sep 20, 2022

Did the PR above fix this?

@yjbanov
Copy link
Contributor

yjbanov commented Sep 27, 2022

Did the PR above fix this?

Hard to tell because when we skip goldens we don't send them to Skia Gold any more. I'm working on #111325 so we can verify flake fixes. Also, will drop the priority of this, since the test is skipped and not causing build breakages.

@yjbanov yjbanov added P1 High-priority issues at the top of the work list and removed P2 labels Sep 27, 2022
@flutter-triage-bot flutter-triage-bot bot added team-web Owned by Web platform team triaged-web Triaged by Web platform team labels Jul 8, 2023
@flutter-triage-bot
Copy link

This issue is assigned but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@flutter-triage-bot flutter-triage-bot bot removed the triaged-web Triaged by Web platform team label Jul 9, 2023
@flutter-triage-bot flutter-triage-bot bot added the Bot is counting down the days until it unassigns the issue label Jul 30, 2023
@yjbanov yjbanov assigned harryterkelsen and unassigned yjbanov Sep 28, 2023
@yjbanov
Copy link
Contributor

yjbanov commented Sep 28, 2023

Reassigned to @harryterkelsen who's actively overhauling how screenshots are taken in CanvasKit mode.

@harryterkelsen
Copy link
Contributor

Should be fixed by #135249

Using Scene.toImage should be more stable than browser screenshot APIs

@flutter-triage-bot flutter-triage-bot bot removed the Bot is counting down the days until it unassigns the issue label Sep 28, 2023
@flutter-triage-bot
Copy link

This issue is assigned to @harryterkelsen but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@flutter-triage-bot flutter-triage-bot bot added the Bot is counting down the days until it unassigns the issue label Feb 8, 2024
@yjbanov yjbanov added the triaged-web Triaged by Web platform team label Feb 22, 2024
@flutter-triage-bot flutter-triage-bot bot removed the Bot is counting down the days until it unassigns the issue label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer: huggsy (g3) dependency: skia Skia team may need to help us P1 High-priority issues at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants