New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvaskit datepicker skiagold tests are flaky #110785
Comments
In particular, at least the following appear to be producing inconsistent results across runs:
|
Since the CanvasKit roll was reverted, dropping priority to P2. |
Update: still discussing what the right solution is here. |
Did the PR above fix this? |
Hard to tell because when we skip goldens we don't send them to Skia Gold any more. I'm working on #111325 so we can verify flake fixes. Also, will drop the priority of this, since the test is skipped and not causing build breakages. |
This issue is assigned but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks! |
Reassigned to @harryterkelsen who's actively overhauling how screenshots are taken in CanvasKit mode. |
Should be fixed by #135249 Using |
This issue is assigned to @harryterkelsen but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks! |
Internal: b/292548039
Since the most recent canvaskit roll, these tests are producing new skia diffs on nearly every run. This is closing the framework tree, and blocking rolls.
cc @yjbanov
The text was updated successfully, but these errors were encountered: