Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web:a11y] input.value test is a noop #147200

Open
yjbanov opened this issue Apr 22, 2024 · 0 comments
Open

[web:a11y] input.value test is a noop #147200

yjbanov opened this issue Apr 22, 2024 · 0 comments
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team

Comments

@yjbanov
Copy link
Contributor

yjbanov commented Apr 22, 2024

Just noticed, while working on something else, that we have this line in our tests:

https://github.com/flutter/engine/blob/aeb987bce6ecf47e15de33ca7c0b0f85b6a0eb42/lib/web_ui/test/engine/semantics/semantics_test.dart#L1773

It is attempting to check that the <input> element has a value of "hello". However, because outerHTML strips away the value property, the test results in a false positive. The value is actually empty.

I'm not yet sure if this is a bug, but I'm filing this to leave a TODO and look into it later.

@yjbanov yjbanov added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically P2 Important issues not at the top of the work list team-web Owned by Web platform team triaged-web Triaged by Web platform team engine flutter/engine repository. See also e: labels. labels Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
None yet
Development

No branches or pull requests

1 participant