-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flutter seemingly not pushing new dev builds without first running flutter clean
#147752
Comments
To whomever first tries to look at this - I am available to pair up and investigate what is going on. |
cc @andrewkolos |
@craiglabenz |
Reproducible on master
Hot Restart seems to push the updated code
Changing code and recompiling will now build that state instead rather than the latest state. This issue is very disruptive as it can easily mislead the developer. This is especially bad if the developer is trying to fix a difficult bug as it can make him think that his new code is not fixing the bug in question. |
It just happened to me in production! With
Build took shorter time and installing the release with
Resulted in an old version being installed on the device. This is now much more serious @christopherfujino @andrewkolos Running Same with iOS releases it actually deployed a wrong build! |
Hot reload/restart definitely is affected also - it no longer works in all cases either - it may seem to work in some cases, but it often no longer works. It does not matter if the debugger is being used or not. The only way to develop with the current master channel is to ALWAYS This bug should be of the highest priority - the build environment is essentially totally broken in all cases. |
This may be related to #147643 |
Great news - that would also mean #147709 should be our fix. |
Update: #147709 does seem to fix this broken behavior for me. For anyone on the |
I can confirm that #147709 does fix this issue for me. I have been testing it for the last few hours on several projects and changes I make are being correctly incorporated into builds and hot reloads. (I applied the changes to my Here's to hoping that #147709 gets merged into the master channel ASAP (for others sake - my environment works now 😄 ) This bug was and will continue to be a real time waster for developers on the master channel until it is fixed. It is confusing as heck when changes you are making are not being incorporated into builds! |
#147709 has merged, so I believed this issue should be resolved. Feel free to reopen if this is not the case. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Steps to reproduce
I have repeatedly seen
$ flutter run
not ship new builds to a test device (which has included physical Android and iOS devices, and also macOS desktop) without first running$ flutter clean
.I first encountered this bug earlier this week when @schmidt-sebastian was unable to successfully rebuild an example on his test Android device in a project we are working on together.
Then, I saw the error myself yesterday pushing the same project to my iOS device.
And then this morning while livestreaming, I encountered it again on an unrelated project. The part where I start encountering new code not getting executed begins here, after some unrelated distractions resumes with a compilation error during an attempted hot reload here, and then concludes with me eventually using
$ flutter clean
here.Expected results
$ flutter run
should either ship the new app or fail loudly.Actual results
$ flutter run
either silently fails to compile and ships the old build, or just ships the old build regardless.Code sample
I will revisit a minimal reproduction soon, but wanted to at least start documenting this since I no longer believe it is simple user error.
Screenshots or Video
No response
Logs
No response
Flutter Doctor output
Doctor output
The text was updated successfully, but these errors were encountered: