Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[et] The tool doesn't handle non-terminal type stdout and stderr correctly. #147936

Closed
chinmaygarde opened this issue May 7, 2024 · 3 comments
Closed
Labels
e: engine-tool Engine-specific tooling (i.e. `tools/engine_tool`). team-engine Owned by Engine team

Comments

@chinmaygarde
Copy link
Member

The tool want to display a progress bar and the latest target being compiled prettily to the terminal. And it does that. However for non terminal type stdout/stderr (IIRC checked via isatty and GetConsoleScreenBufferInfo), the output is a bit of a mess. For instance, via Gnu parallel, invoking parallel et build -c ::: host_profile_arm64 android_profile_arm64 will dump a whole mess of text that is hard to parse. The same happens when the build system is invoked via editor build system integration.

An instance of the text output:
Screenshot 2024-05-07 at 11 22 17 AM

@chinmaygarde chinmaygarde added team-engine Owned by Engine team e: engine-tool Engine-specific tooling (i.e. `tools/engine_tool`). labels May 7, 2024
@chinmaygarde
Copy link
Member Author

chinmaygarde commented May 7, 2024

I don't know if #147903 is tracking a flag that explicitly opts out of pretty printing of if this is just a straight up duplicate. But, if its a flag, we should flip default its value to isatty. cc @matanlurey

@chinmaygarde chinmaygarde changed the title [et] The tools doesn't handle non-terminal type stdout and stderr correctly. [et] The tool doesn't handle non-terminal type stdout and stderr correctly. May 7, 2024
@matanlurey
Copy link
Contributor

Duplicate of #147903.

@matanlurey matanlurey closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: engine-tool Engine-specific tooling (i.e. `tools/engine_tool`). team-engine Owned by Engine team
Projects
None yet
Development

No branches or pull requests

2 participants