Support Radio.adaptive for RadioMenuButton

[huycozy]

Use case

RadioMenuButton uses Radio fixedly which supports Material Design only.

flutter/packages/flutter/lib/src/material/menu_anchor.dart

Line 1576 in 1fba66d

child: Radio<T>(

Proposal

Since we have Radio.adaptive, could we also have RadioMenuButton.adaptive?

Radio	Radio.adaptive

[victorsanni]

Same for CheckboxMenuButton:

flutter/packages/flutter/lib/src/material/menu_anchor.dart

Line 1387 in c03fb95

child: Checkbox(

[gerteck]

Could I give a try at contributing to this issue?

I would attempt to implement RadioMenuButton.adaptive following Radio.adaptive's implementation.

[victorsanni]

Could I give a try at contributing to this issue?

I would attempt to implement RadioMenuButton.adaptive following Radio.adaptive's implementation.

A good first step would be defining a new RadioMenuButton.adaptive constructor. Then, in RadioMenuButton's build method, conditionally set the child property to either a Radio or Radio.adaptive depending on the type of the RadioMenuButton.

A similar pattern can be found here in CheckboxListTile using the _CheckboxType enum.

[gerteck]

A good first step would be defining a new RadioMenuButton.adaptive constructor. Then, in RadioMenuButton's build method, conditionally set the child property to either a Radio or Radio.adaptive depending on the type of the RadioMenuButton.

A similar pattern can be found here in CheckboxListTile using the _CheckboxType enum.

Got it! I've done so accordingly, I added both a _CheckboxType and a _RadioType enum, and conditionally set the child property accordingly. However, I didn't use a switch-case approach, but I'll modify it accordingly to match, and it does make the code easier to follow.

As per Tree-hygiene.md, I have yet to add any additional testcases for the changes made. I'm not entirely clear on how I should go about doing this. Should I:

• Commit the changes I've made on my own branch, open a PR linking this issue, and work on testcases thereafter while seeking guidance if needed.
• or
• Work on the testcases first, and commit and open a PR only when I'm done.

Thank you for the previous reply! @victorsanni

[victorsanni]

@gerteck both are valid.

[Piinks]

From #149714, if we do implement a adaptive RadioMenuButton or CheckboxMenuButton, we should be able to strip way any material aspects like the ink splash when adapting to a cupertino look and feel.