Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate __FlutterEngineFlushPendingTasksNow and allow embedder to create their own threads and message loops. #16912

Closed
chinmaygarde opened this issue Apr 24, 2018 · 5 comments
Labels
e: embedder Users of the Embedder API engine flutter/engine repository. See also e: labels.

Comments

@chinmaygarde
Copy link
Member

__FlutterEngineFlushPendingTasksNow was added as a workaround for embedders to flush tasks on threads where the engine didn't own the message loop (or couldn't interact with the same as is the case on Android and Darwin). This API is hard to use and was a temporary hack. Remove the same and allow embedders to specify thread up front. This API has landed on the C++ side via the TaskRunner configuration passed to the Shell::Create call. This has to be wrapped up in the stable C API and exposed to custom embedders.

@chinmaygarde chinmaygarde added the e: embedder Users of the Embedder API label Apr 24, 2018
@chinmaygarde
Copy link
Member Author

XRef: b/77652157

@stuartmorgan
Copy link
Contributor

@chinmaygarde is there anything left to do here other than mark the API as deprecated? The recent platform message loop API that was added is what's needed to move off of __FlutterEngineFlushPendingTasksNow, right?

@chinmaygarde
Copy link
Member Author

Yes. Embedders should have everything they need to move off of this API.

@chinmaygarde
Copy link
Member Author

Fixed in flutter/engine#8273

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: embedder Users of the Embedder API engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

No branches or pull requests

3 participants