SliverFillRemaining fill more than remaining space available

[asoseil]

It seems that SliverFillRemaining fills a space with a height equal to the height of the viewport and not equal to remaining available space.

new CustomScrollView(
        slivers: <Widget>[
          new SliverToBoxAdapter(
          child: new Container(color: Colors.red,
          height: 150.0,
          )),
          new SliverFillRemaining(
            child: new Container(color: Colors.white),
          )
        ],
      )

[kbrz]

Same thing happens to me. Having CustomScrollView with SliverAppBar, SliverList using SliverChildBuilderDelegate and SliverFillRemaining results in SliverFillRemaining's height equal to viewport's height. So I can scroll until last element of the list is scrolled out of the screen.

[figengungor]

+1

[fit-aditya]

I can confirm this is the behavior as of 0.11.3, any workarounds?

Edit: there is some unexpected behavior -

1. Create a CustomScrollView with SliverAppBar and SliverFillRemaining
2. Add a FractionallySizedBox inside SliverFillRemaining with heightFactor 0.5 and a Container with color green
3. Scrolling the UI changes height of the FractionallySizedBox

How is scrolling adding height to the SliverFillRemaining?

[lubritto]

@zoechi Any update ?

[aloisdeniel]

Not working for me too.

After profiling the source code, it seems that the issue comes from :

aloisdeniel@54952a9#diff-85d3eb0d3e238772f866f76eab9b7acd

When replacing with scrollExtent: constraints.scrollOffset, I get the expected behaviour.

[thekeenant]

This helped me out: https://pub.dartlang.org/packages/sliver_fill_remaining_box_adapter
I didn't look into how it works/fixed the issue I was facing, but it seems related to the issue reported here.

[minhdtb]

I got the same issue. Any update now?

[dnfield]

Was looking at this with @chunhtai and @Piinks - it seems like changing line 127 of sliver_fill.dart to

 scrollExtent: extent,

Fixes this but breaks the nested scroll view tests. It's possible those nested scroll view tests are incorrect. @Piinks says she'll look into it a bit more.

[ziakhan110]

any fix for this yet?

[Piinks]

... it seems like changing line 127 of sliver_fill.dart to

 scrollExtent: extent,

Fixes this but breaks the nested scroll view tests. It's possible those nested scroll view tests are incorrect.

This appears to not only break the NestedScrollView tests, but also breaks the expected physics in regards to the iOS bounce at the top and bottom of the CustomScrollView.

When replacing with scrollExtent: constraints.scrollOffset, I get the expected behaviour.

Does seem to work for this issue. I think that the use cases for SliverFillRemaining on its own in the sample code above and within NestedScrollView have different behavior expectations.

I have a PR up now (#33627) that instead creates a flag for SliverFillRemaining to be able to specify which behavior you want from this widget. Currently, it defaults to work appropriately in this situation.

[chloe722]

+1

[eliwowlol123]

This helped me out: https://pub.dartlang.org/packages/sliver_fill_remaining_box_adapter
I didn't look into how it works/fixed the issue I was facing, but it seems related to the issue reported here.

thanks, you are a g-d

[niallshaw]

I don't think this issue should be closed.

[hamishjohnson]

I'm not sure what @Piinks PR fixed here?
@dnfield solution to

seems like changing line 127 of sliver_fill.dart to

 scrollExtent: extent,

Isn't available anymore, and the issue is not related to NestedScrollViews. The issue still exists

[Piinks]

I'm not sure what @Piinks PR fixed here?
@dnfield solution to

seems like changing line 127 of sliver_fill.dart to

 scrollExtent: extent,

Isn't available anymore, and the issue is not related to NestedScrollViews. The issue still exists

@magpiedigital I would recommend filing a new issue with a code sample that reproduces the bug you are experiencing along with the output of flutter doctor -v . Feel free to ping me on it and we can take a look! :)

[hamishjohnson]

It's the same issue as the OP and their code is all you need to reproduce the bug. Just scroll down. Perhaps I'm wrong, but my expected behavior is that it works like a sliver version of Expanded widget.

[Piinks]

It's the same issue as the OP and their code is all you need to reproduce the bug. Just scroll down. Perhaps I'm wrong, but my expected behavior is that it works like a sliver version of Expanded widget.

The OP was solved by the introduction of SliverFillRemaining.hasScrollBody, which defaults to true. By default, SliverFillRemaining will maintain the behavior of the OP, but by using hasScrollBody: false, it is solved. There are several sample apps that demonstrate different use cases in the api documentation: https://master-api.flutter.dev/flutter/widgets/SliverFillRemaining-class.html

If you find you are still experiencing an issue, please file a new bug. Thanks! :)

[dvirgiln]

I opened a similar issue. It seems that using TabBar and setting hasScrollBody:false does not make it to work.

#75517

[dvirgiln]

@Piinks could you have a look to the ticket I opened. It is quite related.

Thanks

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.