Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Engine should consider banning static initializers #18588

Open
eseidelGoogle opened this issue Jun 19, 2018 · 3 comments
Open

Flutter Engine should consider banning static initializers #18588

eseidelGoogle opened this issue Jun 19, 2018 · 3 comments
Labels
engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@eseidelGoogle
Copy link
Contributor

See Chromium's policy and reasoning:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/static_initializers.md
http://neugierig.org/software/chromium/notes/2011/08/static-initializers.html

Unless maybe already our build rules do? @chinmaygarde might know.

@chinmaygarde
Copy link
Member

No. Our current build rules do not ban static initializers. Though, I have tried addding the same in the past. There are a few dependencies that do not compile with that updated options. I think we should ban them in engine code to start and then expand scope from there.

@zoechi zoechi added the engine flutter/engine repository. See also e: labels. label Aug 26, 2018
@pedromassangocode
Copy link

Is this still a valid issue?

@chinmaygarde
Copy link
Member

Yes. We have fewer globals and singletons in the engine than when this issue was first written. But getting rid of a few (especially some in our dependencies) is hard. Maybe we can consider a ban for additions.

@chinmaygarde chinmaygarde added the P3 Issues that are less important to the Flutter project label Oct 2, 2020
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Development

No branches or pull requests

5 participants