Cupertino fullscreenDialog breaks parallax effect #20073
Labels
a: fidelity
Matching the OEM platforms better
f: cupertino
flutter/packages/flutter/cupertino repository
f: routes
Navigator, Router, and related APIs.
framework
flutter/packages/flutter repository. See also f: labels.
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
platform-ios
iOS applications specifically
Comments
|
Please add the output of |
|
Oh right, here's the output: |
zoechi
added
framework
|
And here's a code sample: import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
onGenerateRoute: (RouteSettings settings) {
switch (settings.name) {
case '/':
return CupertinoPageRoute<void>(
builder: (_) => Home(),
settings: settings,
);
}
},
);
}
}
class Home extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: Text('Home')),
body: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
FlatButton(
child: Text('Page A with fullscreenDialog: false'),
onPressed: () {
Navigator.push(
context,
CupertinoPageRoute<void>(
builder: (_) => PageA(),
fullscreenDialog: false,
));
},
),
SizedBox(height: 25.0),
FlatButton(
child: Text('Page A with fullscreenDialog: true'),
onPressed: () {
Navigator.push(
context,
CupertinoPageRoute<void>(
builder: (_) => PageA(),
fullscreenDialog: true,
));
},
),
],
),
),
);
}
}
class PageA extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: Text('Page A')),
body: Center(
child: FlatButton(
child: Text(
'Page B (IMPORTANT: current Page A should move with parallax '
'effect to the left!)',
textAlign: TextAlign.center,
),
onPressed: () {
Navigator.push(
context, CupertinoPageRoute<void>(builder: (_) => PageB()));
},
),
),
);
}
}
class PageB extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: Text('Page B')),
body: Padding(
padding: EdgeInsets.all(20.0),
child: Center(
child: Text(
'''\
Please check:
1. This page should enter from the right.
2. Page A should always move to the left with parallax effect.''',
textAlign: TextAlign.center,
),
),
),
);
}
} |
|
This is sensible. In iOS equivalent, it's a bit convoluted but if your A and B are wrapped in their own UINavigationController and the navigation controller was presented modally and B was shown from A, A would slide up on the way in and slide to the left in a parallax motion on the way out. Should fix in Flutter. |
TahaTesser
added
f: routes
|
Issue still exist on flutter doctor -v |
Mobile - iOS fidelity review
automation
moved this from Awaiting Triage
to Engineer Reviewed
Mar 28, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The bug appears with
MaterialPageRouteon iOS orCupertinoPageRouteon iOS & Android.We push the following pages in this order via the Navigator:
home -> A -> B.If A is pushed with
fullscreenDialog: falseand then we push B withfullscreenDialog: false, B enters the screen from the right and A moves to the left (with parallax effect => everything correct).However, if A is pushed with
fullscreenDialog: trueand then B withfullscreenDialog: false, B enters the screen from the right, but A has no parallax effect.This makes no sense because when pushing B, the parallax effect for A should only depend on how B enters the screen (from the right => parallax, from the bottom => no parallax). Currently it depends on how A was pushed.
The text was updated successfully, but these errors were encountered: