Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerformanceOverlay: It's not clear which time series shows what #22663

Closed
letsar opened this issue Oct 4, 2018 · 3 comments
Closed

PerformanceOverlay: It's not clear which time series shows what #22663

letsar opened this issue Oct 4, 2018 · 3 comments
Labels
framework flutter/packages/flutter repository. See also f: labels.

Comments

@letsar
Copy link
Contributor

letsar commented Oct 4, 2018

The documentation says:

The overlay show two time series. The first shows how much time was required on this thread to produce each frame. The second shows how much time was required on the GPU thread to produce each frame.

The first means the top or the bottom one?

On flutter.io website we have this image (https://flutter.io/ui-performance/):
performance-overlay-green

The top graph is labelled GPU, an and the bottom one UI.
To me, first means top and in that case it looks like it's the opposite. Did I misunderstood something?
@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. d: website - content labels Oct 4, 2018
@zoechi zoechi added this to the Goals milestone Oct 4, 2018
@GaryQian
Copy link
Contributor

GaryQian commented Oct 4, 2018

Yes, the bottom one should be the UI thread on CPU. The top is GPU rasterization time.

We should fix that.

@GaryQian GaryQian mentioned this issue Oct 4, 2018
Merged
@GaryQian
Copy link
Contributor

Merged in. Also updated in other places. Thanks for your contribution! We appreciate it!

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zoechi @GaryQian @letsar